From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53444 invoked by alias); 13 Jun 2018 09:30:00 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 53434 invoked by uid 89); 13 Jun 2018 09:29:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy= X-HELO: smtp4-g21.free.fr Date: Wed, 13 Jun 2018 09:30:00 -0000 From: Albert ARIBAUD To: Florian Weimer Cc: Paul Eggert , libc-alpha@sourceware.org Subject: Re: [PATCH 2/2] Y2038: make __tz_convert compatible with 64-bit-time Message-ID: <20180613112946.09773035@athena> In-Reply-To: <3cc28ef6-ec0a-9359-c75a-5e162ba55c44@redhat.com> References: <20180613070019.4639-1-albert.aribaud@3adev.fr> <20180613070019.4639-3-albert.aribaud@3adev.fr> <14097bbd-ab4c-aec7-f532-23418a120b69@cs.ucla.edu> <3cc28ef6-ec0a-9359-c75a-5e162ba55c44@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SW-Source: 2018-06/txt/msg00296.txt.bz2 Hi Florian, On Wed, 13 Jun 2018 11:14:22 +0200, Florian Weimer wrote : > On 06/13/2018 11:11 AM, Paul Eggert wrote: > > Albert ARIBAUD (3ADEV) wrote: > > > >> -extern void __tz_compute (time_t timer, struct tm *tm, int > >> use_localtime) > >> +extern void __tz_compute (internal_time_t timer, struct tm *tm, int > >> use_localtime) > > > > Why have two types "internal_time_t" and "__time64_t" that are always > > the same? Wouldn't it be simpler to get rid of "internal_time_t" and use > > "__time64_t" uniformly? If we do need two types, the need should be > > documented clearly. > > Yes, we can get rid of internal_time_t if we have __time64_t. Fine for me. > Thanks, > Florian Cordialement, Albert ARIBAUD 3ADEV