From: Albert ARIBAUD <albert.aribaud@3adev.fr>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 2/2] Y2038: make __tz_convert compatible with 64-bit-time
Date: Wed, 13 Jun 2018 09:37:00 -0000 [thread overview]
Message-ID: <20180613113652.0940f3ff@athena> (raw)
In-Reply-To: <900b27d1-a90a-ed3a-e298-1544968a23dd@redhat.com>
Hi Florian,
On Wed, 13 Jun 2018 11:10:09 +0200, Florian Weimer <fweimer@redhat.com>
wrote :
> On 06/13/2018 09:00 AM, Albert ARIBAUD (3ADEV) wrote:
> > + GLIBC_2.28 {
> > + __ctime64; __ctime64_r;
> > + __gmtime64; __gmtime64_r;
> > + __localtime64; __localtime64_r;
> > + }
>
> Functions in the private namespace should be exported as GLIBC_PRIVATE.
> Except __gmtime64_r, these functions have unwanted side effects and
> cannot really be called from other parts of glibc anyway.
They're going to be implementations of APIs called from user source code
if/when it defines _TIME_BITS equal to 64 (that'll be the last patch in
the whole series), so I don't understand how they could be considered
GLIBC_PRIVATE.
As for the side effects, which ones are you thinking of? The ones I am
aware of are those already present in the 32-bit-time versions and are
"regrettable but established behavior".
> Thanks,
> Florian
Cordialement,
Albert ARIBAUD
3ADEV
next prev parent reply other threads:[~2018-06-13 9:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 7:00 [PATCH 0/2] Y2038 support batch 1 - __time64_t and __tz_convert Albert ARIBAUD (3ADEV)
2018-06-13 7:00 ` [PATCH 2/2] Y2038: make __tz_convert compatible with 64-bit-time Albert ARIBAUD (3ADEV)
2018-06-13 9:10 ` Florian Weimer
2018-06-13 9:37 ` Albert ARIBAUD [this message]
2018-06-13 9:40 ` Florian Weimer
2018-06-13 10:21 ` Albert ARIBAUD
2018-06-13 10:55 ` Albert ARIBAUD
2018-06-13 13:08 ` Florian Weimer
2018-06-13 14:29 ` Joseph Myers
2018-06-13 14:24 ` Joseph Myers
2018-06-18 13:34 ` Florian Weimer
2018-06-13 9:11 ` Paul Eggert
2018-06-13 9:14 ` Florian Weimer
2018-06-13 9:30 ` Albert ARIBAUD
2018-06-13 14:22 ` Joseph Myers
2018-06-13 14:18 ` Joseph Myers
2018-06-13 7:00 ` [PATCH 1/2] Y2038: add type __time64_t Albert ARIBAUD (3ADEV)
2018-06-13 8:38 ` Paul Eggert
2018-06-13 12:36 ` Albert ARIBAUD
2018-06-13 14:13 ` Joseph Myers
2018-06-13 16:19 ` Albert ARIBAUD
2018-06-13 16:35 ` Paul Eggert
2018-06-13 16:39 ` Joseph Myers
2018-06-13 18:46 ` Paul Eggert
2018-06-13 7:59 ` [PATCH 0/2] Y2038 support batch 1 - __time64_t and __tz_convert Albert ARIBAUD
2018-06-13 14:08 ` Joseph Myers
2018-06-13 15:38 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180613113652.0940f3ff@athena \
--to=albert.aribaud@3adev.fr \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).