From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80806 invoked by alias); 13 Jun 2018 09:37:00 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 80777 invoked by uid 89); 13 Jun 2018 09:37:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=unwanted, H*r:sk:smtp6-g, H*RU:212.27.42.6, H*RU:sk:smtp6-g X-HELO: smtp6-g21.free.fr Date: Wed, 13 Jun 2018 09:37:00 -0000 From: Albert ARIBAUD To: Florian Weimer Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 2/2] Y2038: make __tz_convert compatible with 64-bit-time Message-ID: <20180613113652.0940f3ff@athena> In-Reply-To: <900b27d1-a90a-ed3a-e298-1544968a23dd@redhat.com> References: <20180613070019.4639-1-albert.aribaud@3adev.fr> <20180613070019.4639-3-albert.aribaud@3adev.fr> <900b27d1-a90a-ed3a-e298-1544968a23dd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SW-Source: 2018-06/txt/msg00298.txt.bz2 Hi Florian, On Wed, 13 Jun 2018 11:10:09 +0200, Florian Weimer wrote : > On 06/13/2018 09:00 AM, Albert ARIBAUD (3ADEV) wrote: > > + GLIBC_2.28 { > > + __ctime64; __ctime64_r; > > + __gmtime64; __gmtime64_r; > > + __localtime64; __localtime64_r; > > + } > > Functions in the private namespace should be exported as GLIBC_PRIVATE. > Except __gmtime64_r, these functions have unwanted side effects and > cannot really be called from other parts of glibc anyway. They're going to be implementations of APIs called from user source code if/when it defines _TIME_BITS equal to 64 (that'll be the last patch in the whole series), so I don't understand how they could be considered GLIBC_PRIVATE. As for the side effects, which ones are you thinking of? The ones I am aware of are those already present in the 32-bit-time versions and are "regrettable but established behavior". > Thanks, > Florian Cordialement, Albert ARIBAUD 3ADEV