From: Albert ARIBAUD <albert.aribaud@3adev.fr>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 1/2] Y2038: add type __time64_t
Date: Wed, 13 Jun 2018 12:36:00 -0000 [thread overview]
Message-ID: <20180613143623.54b211a6@athena> (raw)
In-Reply-To: <08063cdb-eb06-7b47-5020-55852c1b6f96@cs.ucla.edu>
Hi Paul,
On Wed, 13 Jun 2018 01:38:09 -0700, Paul Eggert <eggert@cs.ucla.edu>
wrote :
> Albert ARIBAUD (3ADEV) wrote:
> > -__STD_TYPE __TIME_T_TYPE __time_t; /* Seconds since the Epoch. */
> > +__STD_TYPE __TIME_T_TYPE __time_t; /* Seconds since the Epoch, Y2038-unsafe. */
>
> This change to commentary is confusing, as __time_t is Y2038-safe on 64-bit
> hosts. I suggest omitting the change, and changing the comment on the next line
> to "Seconds since the Epoch (TIME_BITS==64)" (or whatever the name of that macro
> is).
Fixed locally as suggested, will repost once 2/2 discussion is complete.
Cordialement,
Albert ARIBAUD
3ADEV
next prev parent reply other threads:[~2018-06-13 12:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 7:00 [PATCH 0/2] Y2038 support batch 1 - __time64_t and __tz_convert Albert ARIBAUD (3ADEV)
2018-06-13 7:00 ` [PATCH 2/2] Y2038: make __tz_convert compatible with 64-bit-time Albert ARIBAUD (3ADEV)
2018-06-13 9:10 ` Florian Weimer
2018-06-13 9:37 ` Albert ARIBAUD
2018-06-13 9:40 ` Florian Weimer
2018-06-13 10:21 ` Albert ARIBAUD
2018-06-13 10:55 ` Albert ARIBAUD
2018-06-13 13:08 ` Florian Weimer
2018-06-13 14:29 ` Joseph Myers
2018-06-13 14:24 ` Joseph Myers
2018-06-18 13:34 ` Florian Weimer
2018-06-13 9:11 ` Paul Eggert
2018-06-13 9:14 ` Florian Weimer
2018-06-13 9:30 ` Albert ARIBAUD
2018-06-13 14:22 ` Joseph Myers
2018-06-13 14:18 ` Joseph Myers
2018-06-13 7:00 ` [PATCH 1/2] Y2038: add type __time64_t Albert ARIBAUD (3ADEV)
2018-06-13 8:38 ` Paul Eggert
2018-06-13 12:36 ` Albert ARIBAUD [this message]
2018-06-13 14:13 ` Joseph Myers
2018-06-13 16:19 ` Albert ARIBAUD
2018-06-13 16:35 ` Paul Eggert
2018-06-13 16:39 ` Joseph Myers
2018-06-13 18:46 ` Paul Eggert
2018-06-13 7:59 ` [PATCH 0/2] Y2038 support batch 1 - __time64_t and __tz_convert Albert ARIBAUD
2018-06-13 14:08 ` Joseph Myers
2018-06-13 15:38 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180613143623.54b211a6@athena \
--to=albert.aribaud@3adev.fr \
--cc=eggert@cs.ucla.edu \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).