Re: [PATCH 0/2] Y2038 support batch 1 - __time64_t and __tz_convert

[Albert ARIBAUD <albert.aribaud@3adev.fr>]

Hi Joseph,

On Wed, 13 Jun 2018 14:08:16 +0000, Joseph Myers
<joseph@codesourcery.com> wrote :

> On Wed, 13 Jun 2018, Albert ARIBAUD wrote:
> 
> > These patches have also been tested using build-many-glibcs.py, always
> > for x86_64, aarch64, arm and powerpc compilers, and regularly for all
> > compilers, and found to give the same results as those of the current
> > glibc master above which the patches were created.  
> 
> Since build-many-glibcs.py should give clean results everywhere except 
> i686-gnu, and since this patch adds Versions entries at a public ABI 
> version but has no *.abilist updates, I'm skeptical of the above 
> description of testing.  You should have no ABI test failures before the 
> patch series, anywhere, whether in your normal ARM testing or with 
> build-many-glibcs.py, and without *.abilist updates you should be seeing 
> such failures after the patch series.
>
> Any patch adding new ABIs at public versions always needs to include the 
> ABI baseline updates for *all* glibc configurations.

Right now I only update abilists for ARM and PowerPC as these are
the ones for which I run functional testing. I can update others but I
won't be able to test them functionally.

In any case, I'll group together related changes to Versions and
abilists in the same patch.  

> You should do full execution testing for at least one 64-bit 
> configuration, as well.

My minimal set includes x86_64-linux-gnu, aarch64-linux-gnu,
arm-linux-gnueabi and powerpc-linux-gnu, so this covers two different
64-bit configurations.

(my maximal set is 'all compilers and all glibcs' -- including i686-gnu
for the sake of it -- but as this takes around 30 hours on a reasonably
fast machine, I don't run it for every change.)

Cordialement,
Albert ARIBAUD
3ADEV