public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@gnu.org>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: Zack Weinberg <zackw@panix.com>,
	libc-alpha@sourceware.org, schwab@suse.de
Subject: Re: [PATCH v3?] Avoid cancellable I/O primitives in ld.so.
Date: Wed, 13 Jun 2018 18:30:00 -0000	[thread overview]
Message-ID: <20180613183043.34r6elurt3ugqae6@var.youpi.perso.aquilenet.fr> (raw)
In-Reply-To: <cc467fcc-fc99-dad4-15e1-86da3e5d45f3@linaro.org>

Hello,

Thanks for the Cc :)

Adhemerval Zanella, le lun. 11 juin 2018 23:12:46 -0300, a ecrit:
> > Right now, it appears that Hurd does not implement _nocancel I/O, so
> > sysdeps/generic/not-cancel.h will forward everything back to the
> > regular functions.

Yes, that part needs implementing.

> > This changed the names of some of the functions
> > that sysdeps/mach/hurd/dl-sysdep.c needs to interpose.  I do not fully
> > understand how this works and I would appreciate specific review by
> > Hurd maintainers.

That looks good to me: dl-sysdep.c just needs to expose the symbols that
rtld uses.

> > I am getting test failures for cross compilation
> > to i686-gnu but I *think* this patch does not change the set of
> > failures.  (Other than that, this patch shows no failures whatsoever
> > in a build-many-glibcs cycle.)

I have tried to build a glibc with the patch, programs start fine, so it
is good.

Thanks,
Samuel

      reply	other threads:[~2018-06-13 18:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-07 14:03 Zack Weinberg
2018-06-12  2:13 ` Adhemerval Zanella
2018-06-13 18:30   ` Samuel Thibault [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180613183043.34r6elurt3ugqae6@var.youpi.perso.aquilenet.fr \
    --to=samuel.thibault@gnu.org \
    --cc=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    --cc=schwab@suse.de \
    --cc=zackw@panix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).