From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123976 invoked by alias); 13 Jun 2018 18:30:58 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 122813 invoked by uid 89); 13 Jun 2018 18:30:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_NEUTRAL autolearn=no version=3.3.2 spammy=Hx-spam-relays-external:sk:static-, H*RU:sk:static-, H*r:sk:static-, juin X-HELO: hera.aquilenet.fr Date: Wed, 13 Jun 2018 18:30:00 -0000 From: Samuel Thibault To: Adhemerval Zanella Cc: Zack Weinberg , libc-alpha@sourceware.org, schwab@suse.de Subject: Re: [PATCH v3?] Avoid cancellable I/O primitives in ld.so. Message-ID: <20180613183043.34r6elurt3ugqae6@var.youpi.perso.aquilenet.fr> References: <20180607140252.16562-1-zackw@panix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2018-06/txt/msg00351.txt.bz2 Hello, Thanks for the Cc :) Adhemerval Zanella, le lun. 11 juin 2018 23:12:46 -0300, a ecrit: > > Right now, it appears that Hurd does not implement _nocancel I/O, so > > sysdeps/generic/not-cancel.h will forward everything back to the > > regular functions. Yes, that part needs implementing. > > This changed the names of some of the functions > > that sysdeps/mach/hurd/dl-sysdep.c needs to interpose. I do not fully > > understand how this works and I would appreciate specific review by > > Hurd maintainers. That looks good to me: dl-sysdep.c just needs to expose the symbols that rtld uses. > > I am getting test failures for cross compilation > > to i686-gnu but I *think* this patch does not change the set of > > failures. (Other than that, this patch shows no failures whatsoever > > in a build-many-glibcs cycle.) I have tried to build a glibc with the patch, programs start fine, so it is good. Thanks, Samuel