From: Vincent Chen <vincentc@andestech.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: "libc-alpha@sourceware.org" <libc-alpha@sourceware.org>,
"deanbo422@gmail.com" <deanbo422@gmail.com>,
"Che-Wei Chuang (??????)" <cnoize@andestech.com>
Subject: Re: [PATCH v3 07/13] nds32: Linux Syscall Interface
Date: Fri, 15 Jun 2018 07:47:00 -0000 [thread overview]
Message-ID: <20180615074648.GB30532@andestech.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1806141331580.20120@digraph.polyomino.org.uk>
On Thu, Jun 14, 2018 at 09:33:53PM +0800, Joseph Myers wrote:
> On Thu, 14 Jun 2018, Vincent Chen wrote:
>
> > +/* This routine is jumped to by all the syscall handlers, to stash
> > + an error number into errno. */
> > +long int
> > +__syscall_error (long int err)
> > +{
> > + __set_errno (- err);
>
> We use spaces around binary operators, but not after unary '-'.
>
> > + __set_errno (INTERNAL_SYSCALL_ERRNO (result_var, err)); \
> > + result_var = -1 ; \
>
> No space before ';'. The indentation of the second line here also seems
> way off. Likewise again later in this file.
>
I will modify these mistakes in the next version patch.
Thanks for your comment.
Vincent Chen
> --
> Joseph S. Myers
> joseph@codesourcery.com
next prev parent reply other threads:[~2018-06-15 7:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 7:23 [PATCH v3 00/13] nds32 glibc port, v3 Vincent Chen
2018-06-14 7:23 ` [PATCH v3 03/13] nds32: Thread-Local Storage Support Vincent Chen
2018-06-14 7:23 ` [PATCH v3 01/13] nds32: Build Infastructure Vincent Chen
2018-06-14 13:27 ` Joseph Myers
2018-06-15 7:42 ` Vincent Chen
2018-06-14 7:23 ` [PATCH v3 02/13] nds32: ABI Implementation Vincent Chen
2018-06-14 7:24 ` [PATCH v3 05/13] nds32: Generic <math.h> and soft-fp Routines Vincent Chen
2018-06-14 7:24 ` [PATCH v3 06/13] nds32: Atomic and Locking Routines Vincent Chen
2018-06-14 7:24 ` [PATCH v3 08/13] nds32: Linux ABI Vincent Chen
2018-09-13 12:06 ` Arnd Bergmann
2018-09-17 0:50 ` Vincent Chen
2018-06-14 7:24 ` [PATCH v3 04/13] nds32: Startup and Dynamic Loader Vincent Chen
2018-06-14 7:24 ` [PATCH v3 07/13] nds32: Linux Syscall Interface Vincent Chen
2018-06-14 13:34 ` Joseph Myers
2018-06-15 7:47 ` Vincent Chen [this message]
2018-06-14 7:25 ` [PATCH v3 10/13] Skeleton documentation for the nds32 port Vincent Chen
2018-06-14 7:25 ` [PATCH v3 13/13] Add nds32 port to build-many-glibcs.py Vincent Chen
2018-06-14 7:49 ` [PATCH v3 09/13] nds32: Add ABI list Vincent Chen
2018-06-14 8:34 ` Andreas Schwab
2018-06-14 7:50 ` [PATCH v3 12/13] Add nds32 entries to config.h.in Vincent Chen
2018-06-14 7:50 ` [PATCH v3 11/13] Add Andes nds32 dynamic relocation type to elf/elf.h Vincent Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180615074648.GB30532@andestech.com \
--to=vincentc@andestech.com \
--cc=cnoize@andestech.com \
--cc=deanbo422@gmail.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).