From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128468 invoked by alias); 15 Jun 2018 07:47:03 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 128445 invoked by uid 89); 15 Jun 2018 07:47:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=Hx-languages-length:784 X-HELO: ATCSQR.andestech.com Date: Fri, 15 Jun 2018 07:47:00 -0000 From: Vincent Chen To: Joseph Myers CC: "libc-alpha@sourceware.org" , "deanbo422@gmail.com" , "Che-Wei Chuang (??????)" Subject: Re: [PATCH v3 07/13] nds32: Linux Syscall Interface Message-ID: <20180615074648.GB30532@andestech.com> References: <1528960976-10934-1-git-send-email-vincentc@andestech.com> <1528960976-10934-8-git-send-email-vincentc@andestech.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-DNSRBL: X-MAIL:ATCSQR.andestech.com w5F7kt2u012341 X-SW-Source: 2018-06/txt/msg00436.txt.bz2 On Thu, Jun 14, 2018 at 09:33:53PM +0800, Joseph Myers wrote: > On Thu, 14 Jun 2018, Vincent Chen wrote: > > > +/* This routine is jumped to by all the syscall handlers, to stash > > + an error number into errno. */ > > +long int > > +__syscall_error (long int err) > > +{ > > + __set_errno (- err); > > We use spaces around binary operators, but not after unary '-'. > > > + __set_errno (INTERNAL_SYSCALL_ERRNO (result_var, err)); \ > > + result_var = -1 ; \ > > No space before ';'. The indentation of the second line here also seems > way off. Likewise again later in this file. > I will modify these mistakes in the next version patch. Thanks for your comment. Vincent Chen > -- > Joseph S. Myers > joseph@codesourcery.com