From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-93309-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 92023 invoked by alias); 16 Jun 2018 18:21:05 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 92009 invoked by uid 89); 16 Jun 2018 18:21:04 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=HTo:D*ucla.edu, Hx-languages-length:794
X-HELO: smtp2-g21.free.fr
Date: Sat, 16 Jun 2018 18:21:00 -0000
From: Albert ARIBAUD <albert.aribaud@3adev.fr>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Joseph Myers <joseph@codesourcery.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH v2 2/2] Y2038: make __tz_convert compatible with
 64-bit-time
Message-ID: <20180616202050.05e002da@athena>
In-Reply-To: <6f6e040c-94ec-4e2f-5e12-2ec57e57aa88@cs.ucla.edu>
References: <20180614135116.8767-1-albert.aribaud@3adev.fr>
	<20180614135116.8767-3-albert.aribaud@3adev.fr>
	<de6545e4-530a-8fa8-f980-d2d1b5d996bb@cs.ucla.edu>
	<20180614195149.60f6114d@athena>
	<29ea05e7-d4b0-876a-bf39-29ecf7bfa3da@cs.ucla.edu>
	<alpine.DEB.2.20.1806141938540.17828@digraph.polyomino.org.uk>
	<20180616160254.533870e8@athena>
	<6f6e040c-94ec-4e2f-5e12-2ec57e57aa88@cs.ucla.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-SW-Source: 2018-06/txt/msg00463.txt.bz2

Hi Paul,

On Sat, 16 Jun 2018 07:23:29 -0700, Paul Eggert <eggert@cs.ucla.edu>
wrote :

> Albert ARIBAUD wrote:
> > if I remove the __ctime64 and __ctime64_r defines
> > and then build glibc for x86_64-linux-gnu, the linker stage fails due to
> > nis/nis_print.c lines 336 and 338 referring to an undefined ctime().  
> 
> How about if we fix nis/nis_print.c to use localtime_r and strftime instead of 
> ctime? ctime is not thread-safe, and ctime_r is problematic due to the potential 
> problem of overrunning its output buffer when given outlandish timestamps, so 
> such a fix should be made regardless of the Y2038 changes.

I can do this in a further patch if/when that's agreed upon.

Cordialement,
Albert ARIBAUD
3ADEV