From: Mao Han <han_mao@c-sky.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: c-sky_gcc_upstream@c-sky.com, gnu-csky@mentor.com,
libc-alpha@sourceware.org
Subject: Re: [RFC PATCH v3 01/12] C-SKY: ABI related code
Date: Tue, 03 Jul 2018 08:04:00 -0000 [thread overview]
Message-ID: <20180703080345.GC4317@vmh-VirtualBox> (raw)
In-Reply-To: <alpine.DEB.2.20.1806291636530.24607@digraph.polyomino.org.uk>
On Fri, Jun 29, 2018 at 04:40:10PM +0000, Joseph Myers wrote:
> On Fri, 29 Jun 2018, Mao Han wrote:
>
> > Codes in this patch contains lots of C-SKY ABI related code. They are written
> > accroding to the registers assgnments, relocations, assemblly described
> > in C-SKY CPU ABI Standards and C-SKY CPU manual.
>
> Could you include direct URLs to PDFs of these manuals in the introduction
> to future versions of the patch series (like you gave URLs for your GCC /
> binutils / Linux git repositories)?
>
We currently don't have any technical document put on the internet. I've
asked our toolchain principal to release some. Hopefully they will be
available next time.
> Preprocessor indentation, "# error" inside #if.
>
> > +#else
> > +# define CSKY_ABIV2
> > +#endif
>
> Why do you need this macro rather than just using the predefined
> __CSKYABIV2__ anywhere needing an ABI conditional? (Right now, of course,
> any such ABI conditionals will just have #error for the ABIv1 case, like
> the one here.)
It is some legacy code from our first port on 2013. I don't what it is
used for. I think I'll just remove it.
Best Regards,
Mao Han
next prev parent reply other threads:[~2018-07-03 8:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 7:59 [RFC PATCH v3 00/12] port C-SKY to glibc Mao Han
2018-06-29 7:59 ` [RFC PATCH v3 01/12] C-SKY: ABI related code Mao Han
2018-06-29 16:40 ` Joseph Myers
2018-07-03 8:04 ` Mao Han [this message]
2018-06-29 7:59 ` [RFC PATCH v3 05/12] C-SKY: Atomic and Locking Routines Mao Han
2018-06-29 16:36 ` Joseph Myers
2018-07-03 7:57 ` Mao Han
2018-07-17 20:03 ` Joseph Myers
2018-06-29 7:59 ` [RFC PATCH v3 02/12] C-SKY: TLS support Mao Han
2018-06-29 7:59 ` [RFC PATCH v3 04/12] C-SKY: Hard Float Support Mao Han
2018-06-29 8:00 ` [RFC PATCH v3 11/12] C-SKY: Add build-many-glibcs.py support Mao Han
2018-06-29 16:44 ` Joseph Myers
2018-06-29 8:01 ` [RFC PATCH v3 12/12] C-SKY: Skeleton documentation Mao Han
2018-06-29 8:01 ` [RFC PATCH v3 10/12] C-SKY: Build Infastructure Mao Han
2018-06-29 16:46 ` Joseph Myers
2018-06-29 8:01 ` [RFC PATCH v3 09/12] C-SKY: Linux Startup and Dynamic Loading Code Mao Han
2018-06-29 8:12 ` [RFC PATCH v3 07/12] C-SKY: Linux ABI Mao Han
2018-06-29 16:54 ` Joseph Myers
2018-07-03 8:01 ` Mao Han
2018-06-29 8:12 ` [RFC PATCH v3 03/12] C-SKY: Generic math Routines Mao Han
2018-06-29 8:12 ` [RFC PATCH v3 06/12] C-SKY: Linux Syscall Interface Mao Han
2018-06-29 8:12 ` [RFC PATCH v3 08/12] C-SKY: ABI Lists Mao Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180703080345.GC4317@vmh-VirtualBox \
--to=han_mao@c-sky.com \
--cc=c-sky_gcc_upstream@c-sky.com \
--cc=gnu-csky@mentor.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).