From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58994 invoked by alias); 3 Jul 2018 08:04:29 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 58723 invoked by uid 89); 3 Jul 2018 08:03:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,UNPARSEABLE_RELAY autolearn=no version=3.3.2 spammy=Hx-languages-length:1194, our X-HELO: smtp2200-217.mail.aliyun.com X-Alimail-AntiSpam:AC=CONTINUE;BC=0.09119933|-1;CH=green;FP=0|0|0|0|0|-1|-1|-1;HT=e01e01546;MF=han_mao@c-sky.com;NM=1;PH=DS;RN=4;RT=4;SR=0;TI=SMTPD_---.CLfPkKk_1530605027; Date: Tue, 03 Jul 2018 08:04:00 -0000 From: Mao Han To: Joseph Myers Cc: c-sky_gcc_upstream@c-sky.com, gnu-csky@mentor.com, libc-alpha@sourceware.org Subject: Re: [RFC PATCH v3 01/12] C-SKY: ABI related code Message-ID: <20180703080345.GC4317@vmh-VirtualBox> References: <1c2031c79377fb4edbb68a813cd27846534fa98a.1530246556.git.han_mao@c-sky.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-SW-Source: 2018-07/txt/msg00050.txt.bz2 On Fri, Jun 29, 2018 at 04:40:10PM +0000, Joseph Myers wrote: > On Fri, 29 Jun 2018, Mao Han wrote: > > > Codes in this patch contains lots of C-SKY ABI related code. They are written > > accroding to the registers assgnments, relocations, assemblly described > > in C-SKY CPU ABI Standards and C-SKY CPU manual. > > Could you include direct URLs to PDFs of these manuals in the introduction > to future versions of the patch series (like you gave URLs for your GCC / > binutils / Linux git repositories)? > We currently don't have any technical document put on the internet. I've asked our toolchain principal to release some. Hopefully they will be available next time. > Preprocessor indentation, "# error" inside #if. > > > +#else > > +# define CSKY_ABIV2 > > +#endif > > Why do you need this macro rather than just using the predefined > __CSKYABIV2__ anywhere needing an ABI conditional? (Right now, of course, > any such ABI conditionals will just have #error for the ABIv1 case, like > the one here.) It is some legacy code from our first port on 2013. I don't what it is used for. I think I'll just remove it. Best Regards, Mao Han