From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73689 invoked by alias); 17 Jul 2018 12:50:46 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 73676 invoked by uid 89); 17 Jul 2018 12:50:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.2 spammy= X-HELO: bombadil.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=8ZOsD2uE7LCWLvp/jX4fIURT+jxvvRUYJAQGsUlUpLY=; b=ZDAKxxhMmUx7nwh5299DlbySe DcGuhX3d9aDdpLKPEA6oMBwInkdEQuHFJGNGTxanjiTkt3ybd7ru5IDtiogGyzbCAvj9Q2ik6RnEl XAz+qf8cUGDLPNkFHTguqeB3P6Jasq97+pxQmCfsv+VXZtx74jG4hBQOiydATPpwr3mw0ZAjde3kd IZE1WIdkOs15RhumzOUW0m8gzZs9v0sDewUc68Njran3Kr/zhHYZHUpKcoJLC5N69at480Bk2qOQK xFZnUv9ST6sf898AaBHDX/4wlKCTIKa1iK7bPpWJQvp6EcfGS8zBd54XmNo5r+qMcQzviGhgiJMPn 7O+w70/vQ==; Date: Tue, 17 Jul 2018 12:50:00 -0000 From: Christoph Hellwig To: Arnd Bergmann Cc: tglx@linutronix.de, y2038@lists.linaro.org, hch@infradead.org, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, libc-alpha@sourceware.org, albert.aribaud@3adev.fr, netdev@vger.kernel.org, viro@zeniv.linux.org.uk, peterz@infradead.org, dvhart@infradead.org, ebiederm@xmission.com, linux@dominikbrodowski.net Subject: Re: [PATCH v2 02/17] y2038: Remove newstat family from default syscall set Message-ID: <20180717125039.GB25416@infradead.org> References: <20180716161103.16239-1-arnd@arndb.de> <20180716161103.16239-3-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180716161103.16239-3-arnd@arndb.de> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-SW-Source: 2018-07/txt/msg00492.txt.bz2 On Mon, Jul 16, 2018 at 06:10:48PM +0200, Arnd Bergmann wrote: > We have four generations of stat() syscalls: > - the oldstat syscalls that are only used on the older architectures > - the newstat family that is used on all 64-bit architectures but > lacked support for large files on 32-bit architectures. > - the stat64 family that is used mostly on 32-bit architectures to > replace newstat > - statx() to replace all of the above, adding 64-bit timestamps among > other things. > > We already compile stat64 only on those architectures that need it, > but newstat is always built, including on those that don't reference > it. This adds a new __ARCH_WANT_NEW_STAT symbol along the lines of > __ARCH_WANT_OLD_STAT and __ARCH_WANT_STAT64 to control compilation of > newstat. All architectures that need it use an explict define, the > others now get a little bit smaller, and future architecture (including > 64-bit targets) won't ever see it. > > Acked-by: Geert Uytterhoeven > Signed-off-by: Arnd Bergmann Do I read this right that you only want to provide statx by default? It is a little different from the traditional stat calls, so I'd like to know this is actually ok from libc folks first.