From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97234 invoked by alias); 17 Jul 2018 12:52:51 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 97197 invoked by uid 89); 17 Jul 2018 12:52:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.2 spammy= X-HELO: bombadil.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=dXGhg0RmAmqaDXur2sBGsNXXHwXmy4OFx1UCeuAvl4c=; b=YgDG8Ak5km5EYZhhmipaJwa75 OYjAtLggzdJoDQLWujERgtfHGr9FcufzbplUDpLR4wKWCY/2hUtLPdUT3G05sBEnzevXJdUEISwzp oQsON+TYp3AcRvfQ6FaRS9K6heMfvjR85FCk69TRs6LSVn7NyHimDM5QFrefXOLPdWXj6vkIxYT93 vyZoBjHikN2YVq0JrITdTts3MpGMydRytKhA7HbA8H5YZ8MtZoNMUWU+94kD8WZ3yBUzpT7BFm3uO TT8kxZ8ilnLQNiRcTHY+8j/pGaa9vMSZ4LP/xjX9wUU3GTrFv3kd6sZoA0q5EByR2aeRC4RAWHXaP zdmy4DjuQ==; Date: Tue, 17 Jul 2018 12:52:00 -0000 From: Christoph Hellwig To: Arnd Bergmann Cc: tglx@linutronix.de, y2038@lists.linaro.org, hch@infradead.org, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, libc-alpha@sourceware.org, albert.aribaud@3adev.fr, netdev@vger.kernel.org, viro@zeniv.linux.org.uk, peterz@infradead.org, dvhart@infradead.org, ebiederm@xmission.com, linux@dominikbrodowski.net Subject: Re: [PATCH v2 06/17] y2038: Change sys_utimensat() to use __kernel_timespec Message-ID: <20180717125243.GE25416@infradead.org> References: <20180716161103.16239-1-arnd@arndb.de> <20180716161103.16239-7-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180716161103.16239-7-arnd@arndb.de> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-SW-Source: 2018-07/txt/msg00495.txt.bz2 On Mon, Jul 16, 2018 at 06:10:52PM +0200, Arnd Bergmann wrote: > When 32-bit architectures get changed to support 64-bit time_t, > utimensat() needs to use the new __kernel_timespec structure as its > argument. > > The older utime(), utimes() and futimesat() system calls don't need a > corresponding change as they are no longer used on C libraries that have > 64-bit time support. > > As we do for the other syscalls that have timespec arguments, we reuse > the 'compat' syscall entry points to implement the traditional four > interfaces, and only leave the new utimensat() as a native handler, > so that the same code gets used on both 32-bit and 64-bit kernels > on each syscall. I wonder about the direction here: wouldn't it be easier to just leave th existing syscall names as-is and introduce a new utimesat64 which uses the new timespec? We can then drop the old legacy utimesat for new architectures added after the cutover.