From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116451 invoked by alias); 29 Jul 2018 14:20:01 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 115335 invoked by uid 89); 29 Jul 2018 14:20:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=HX-Received:4401, HX-Received:sk:k1-v6mr, H*RU:209.85.160.67, Hx-spam-relays-external:209.85.160.67 X-HELO: mail-pl0-f67.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ebRK6hs83ESiKr343XAyD/SBb69a7ElQ2Tobm4hq2YI=; b=gG9nxembTc7Nt9D94XsaGozcAVZzSJXSE8jH7PniA2EVUGPFjEWly7/VuS10quH1in Yc9T59Gxl/LGkoif2AAnpXpc9StB/DZsPDOLOtmeg7ZQunM+n662DZcYFaT6NhsTnpnG C1UkFVl7JtmbReLBKEF/BC4QLJdRVHCGdkZ1c/wOEp1mXIT3m8Uq9DxP4N/FIlAGJtsm AdV1lyvlOHJanJaJ6UlKn889acRw/mKVVNe8+6B045NXYL37592GhrjgKS56nQHGO1k2 WlcIi4FZp4LNv0tVZZKG/UZ6lh+4Jkmv7RYdxEU5PlcTv6CyJUfr0TWof5apgR3KzpDi /e0A== Return-Path: Date: Sun, 29 Jul 2018 14:20:00 -0000 From: "H.J. Lu" To: Florian Weimer , GNU C Library Subject: V2 [PATCH] x86: Add tst-get-cpu-features-static to $(tests) [BZ #23458] Message-ID: <20180729141956.GA9314@gmail.com> References: <20180727203837.11828-1-hjl.tools@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) X-SW-Source: 2018-07/txt/msg01021.txt.bz2 On Fri, Jul 27, 2018 at 02:41:23PM -0700, H.J. Lu wrote: > On Fri, Jul 27, 2018 at 2:14 PM, Florian Weimer wrote: > > On 07/27/2018 10:38 PM, H.J. Lu wrote: > >> > >> -tests += tst-get-cpu-features > >> +# NB: All tests should be added to $(tests) and all static tests should > >> +# be added to $(tests-static). > >> +tests += tst-get-cpu-features tst-get-cpu-features-static > > > > > > Why the comment? What makes this instance so special to warrant one? > > > > I can take out the comment. > Here is the updated patch. OK for master? Thanks. H.J. --- All tests should be added to $(tests). [BZ #23458] * sysdeps/x86/Makefile (tests): Add tst-get-cpu-features-static. --- sysdeps/x86/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sysdeps/x86/Makefile b/sysdeps/x86/Makefile index 672bb19489..337b0b63dc 100644 --- a/sysdeps/x86/Makefile +++ b/sysdeps/x86/Makefile @@ -5,7 +5,7 @@ endif ifeq ($(subdir),elf) sysdep-dl-routines += dl-get-cpu-features -tests += tst-get-cpu-features +tests += tst-get-cpu-features tst-get-cpu-features-static tests-static += tst-get-cpu-features-static endif -- 2.17.1