From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: libc-alpha@sourceware.org
Cc: linux-snps-arc@lists.infradead.org,
Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
Joseph Myers <joseph@codesourcery.com>,
Andreas Schwab <schwab@suse.de>
Subject: [PATCH v2] tst-tzset: Use default timeout (20 seconds as of now)
Date: Mon, 30 Jul 2018 16:13:00 -0000 [thread overview]
Message-ID: <20180730161334.26026-1-abrodkin@synopsys.com> (raw)
The timeout was set to 5 seconds in commit
112f28e88c4e ("tst-tzset: raise timeout to 5 seconds") to increase it
from a default 2 seconds.
That was before the default timeout was changed to 20 seconds in commit
a28605b22946 (" test-skeleton: increase default TIMEOUT to 20 seconds").
If there's no good reason to limit execution time to less than default
we shouldn't specify random values. That said in tst-tzset we'll be
using default 20 seconds from now on.
Cc: Joseph Myers <joseph@codesourcery.com>
Cc: Andreas Schwab <schwab@suse.de>
---
Changes v1 -> v2:
* Rely on default timeout instead of test-specific one
timezone/tst-tzset.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/timezone/tst-tzset.c b/timezone/tst-tzset.c
index 27f986b56dab..fca704c2ad2d 100644
--- a/timezone/tst-tzset.c
+++ b/timezone/tst-tzset.c
@@ -25,7 +25,6 @@
#include <time.h>
#include <unistd.h>
-#define TIMEOUT 5
static int do_test (void);
#define TEST_FUNCTION do_test ()
#include "../test-skeleton.c"
--
2.17.1
reply other threads:[~2018-07-30 16:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180730161334.26026-1-abrodkin@synopsys.com \
--to=alexey.brodkin@synopsys.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).