From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93950 invoked by alias); 1 Aug 2018 10:25:00 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 93841 invoked by uid 89); 1 Aug 2018 10:24:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_BL_SPAMCOP_NET,RCVD_IN_DNSWL_NONE,URIBL_RED autolearn=ham version=3.3.2 spammy=H*F:D*fr, H*r:212.27.42, freeze X-HELO: smtp4-g21.free.fr Date: Wed, 01 Aug 2018 10:25:00 -0000 From: Albert ARIBAUD To: Joseph Myers Cc: Subject: Re: [PATCH v6 1/2] Y2038: Add 64-bit time for all architectures Message-ID: <20180801122441.49554537@athena> In-Reply-To: References: <20180706174854.546-1-albert.aribaud@3adev.fr> <20180706174854.546-2-albert.aribaud@3adev.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SW-Source: 2018-08/txt/msg00005.txt.bz2 Hi Joseph, On Tue, 17 Jul 2018 22:01:48 +0000, Joseph Myers wrote : > On Fri, 6 Jul 2018, Albert ARIBAUD (3ADEV) wrote: > > > bits/timesize.h | 23 +++++++++++ > > bits/timesizes.h | 37 ++++++++++++++++++ > > The names of these headers are much too similar, and thus too confusing. > (I think it's bits/timesizes.h that should be renamed, as the header has > nothing to do with defining sizes of types.) The file defines the 64-bit time type macro, so would bits/time64.h do? > As previously noted, I consider these changes inappropriate for during the > freeze; early in a release cycle is a much more suitable time. Understood. > > diff --git a/bits/timesize.h b/bits/timesize.h > > new file mode 100644 > > index 0000000000..0739a34df4 > > --- /dev/null > > +++ b/bits/timesize.h > > @@ -0,0 +1,23 @@ > > +/* Bit size of the time_t type at glibc build time, general case. > > + Copyright (C) 2018 Free Software Foundation, Inc. > > + This file is part of the GNU C Library. > > + Contributed by Ulrich Drepper , 2002. > > No "Contributed by" in new files. Overlooked when copy-pasting an existing header, fixed. Cordialement, Albert ARIBAUD 3ADEV