public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Ilya Leoshkevich <iii@linux.ibm.com>
To: libc-alpha@sourceware.org
Cc: stli@linux.ibm.com, Ilya Leoshkevich <iii@linux.ibm.com>
Subject: [PATCH 10/12] Move __fentry__ version definition to sysdeps/{i386,x86_64}
Date: Thu, 02 Aug 2018 08:10:00 -0000	[thread overview]
Message-ID: <20180802075735.3457-11-iii@linux.ibm.com> (raw)
In-Reply-To: <20180802075735.3457-1-iii@linux.ibm.com>

__fentry__ symbol is currently not defined for other architectures.
Attempts to introduce it cause abicheck to fail, because it will be
available since 2.29 earliest, and not 2.13, which is the case for
Intel.  With the new code, abicheck passes for i686-linux-gnu,
x86_64-linux-gnu and x86_64-linux-gnu32 triples.

             * stdlib/Versions: Remove __fentry__.
             * sysdeps/i386/Versions: Add __fentry__.
             * sysdeps/x86_64/Versions: Add __fentry__.
---
 stdlib/Versions         | 3 ---
 sysdeps/i386/Versions   | 3 +++
 sysdeps/x86_64/Versions | 3 +++
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/stdlib/Versions b/stdlib/Versions
index a2dfa322ed..9e665d4c26 100644
--- a/stdlib/Versions
+++ b/stdlib/Versions
@@ -105,9 +105,6 @@ libc {
   GLIBC_2.10 {
     quick_exit; __cxa_at_quick_exit;
   }
-  GLIBC_2.13 {
-    __fentry__;
-  }
   GLIBC_2.17 {
     secure_getenv;
   }
diff --git a/sysdeps/i386/Versions b/sysdeps/i386/Versions
index 7be44aad7a..36e23b466a 100644
--- a/sysdeps/i386/Versions
+++ b/sysdeps/i386/Versions
@@ -25,6 +25,9 @@ libc {
     __strpbrk_cg; __strpbrk_g; __strrchr_c; __strrchr_g; __strspn_c1;
     __strspn_cg; __strspn_g; __strstr_cg; __strstr_g;
   }
+  GLIBC_2.13 {
+    __fentry__;
+  }
 }
 libm {
   GLIBC_2.1 {
diff --git a/sysdeps/x86_64/Versions b/sysdeps/x86_64/Versions
index a437f85e6e..e94758b236 100644
--- a/sysdeps/x86_64/Versions
+++ b/sysdeps/x86_64/Versions
@@ -2,6 +2,9 @@ libc {
   GLIBC_2.14 {
     memcpy;
   }
+  GLIBC_2.13 {
+    __fentry__;
+  }
 }
 libm {
   GLIBC_2.1 {
-- 
2.18.0

  parent reply	other threads:[~2018-08-02  8:10 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-02  7:58 [PATCH 00/12] S390: Implement __fentry__ Ilya Leoshkevich
2018-08-02  7:58 ` [PATCH 02/12] S390: Use symbolic offsets for stack variables in 32-bit _dl_runtime_profile Ilya Leoshkevich
2018-08-02  7:58 ` [PATCH 03/12] S390: Use symbolic offsets for stack variables in 64-bit _dl_runtime_resolve Ilya Leoshkevich
2018-08-02  7:58 ` [PATCH 01/12] S390: Use symbolic offsets for stack variables in 32-bit _dl_runtime_resolve Ilya Leoshkevich
2018-08-02  7:59 ` [PATCH 07/12] S390: Do not clobber R0 in 64-bit _dl_runtime_resolve Ilya Leoshkevich
2018-08-02  7:59 ` [PATCH 12/12] S390: Fix unwind in 32-bit _mcount Ilya Leoshkevich
2018-08-02  7:59 ` [PATCH 09/12] S390: Test that lazy binding does not clobber R0 Ilya Leoshkevich
2018-08-02  7:59 ` [PATCH 08/12] S390: Do not clobber R0 in 64-bit _dl_runtime_profile Ilya Leoshkevich
2018-08-02  7:59 ` [PATCH 11/12] S390: Implement 64-bit __fentry__ Ilya Leoshkevich
2018-08-02  7:59 ` [PATCH 05/12] S390: Do not clobber R0 in 32-bit _dl_runtime_resolve Ilya Leoshkevich
2018-08-02  8:10 ` Ilya Leoshkevich [this message]
2018-08-02  8:41 ` [PATCH 06/12] S390: Do not clobber R0 in 32-bit _dl_runtime_profile Ilya Leoshkevich
2018-08-02  9:00 ` [PATCH 04/12] S390: Use symbolic offsets for stack variables in 64-bit _dl_runtime_profile Ilya Leoshkevich
2018-08-02  9:17 ` [PATCH 00/12] S390: Implement __fentry__ Florian Weimer
2018-08-02 10:43   ` Ilya Leoshkevich
2018-08-02 18:32     ` Florian Weimer
2018-08-07  8:27 ` Stefan Liebler
2018-08-10  7:15   ` [COMMITTED] " Stefan Liebler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180802075735.3457-11-iii@linux.ibm.com \
    --to=iii@linux.ibm.com \
    --cc=libc-alpha@sourceware.org \
    --cc=stli@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).