From: Mao Han <han_mao@c-sky.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: c-sky_gcc_upstream@c-sky.com, gnu-csky@mentor.com,
libc-alpha@sourceware.org
Subject: Re: [PATCH v4 00/13] port C-SKY to glibc
Date: Tue, 18 Sep 2018 06:22:00 -0000 [thread overview]
Message-ID: <20180918062209.GD3355@vmh-VirtualBox> (raw)
In-Reply-To: <alpine.DEB.2.21.1809131222100.27954@digraph.polyomino.org.uk>
On Thu, Sep 13, 2018 at 12:36:15PM +0000, Joseph Myers wrote:
> A different dynamic linker name should be used because the ABI to libc and
> other glibc libraries is incompatible; if you have a different dynamic
> linker name for every ABI, that allows distributions using Debian-style
> multiarch directory arrangements to have libraries for both ABIs installed
> simultaneously. Then, because you can't sensibly use soft-float binaries
> with hard-float libm, you should have the conditionals in bits/fenv.h (a
> single installed header should be set up to work for both ABIs) so that it
> doesn't define macros for unsupported features for soft float.
>
> Once you have the conditionals in bits/fenv.h, the glibc testsuite will
> automatically disable tests for unsupported features for soft float, and
> internal calls to fenv.h functions within libm will automatically be
> optimized out for soft float.
>
OK. I've add different dynamic linker name name for hard-float and put
some conditionals in bits/fenv.h, seems work fine.
> It's not required, but it's a good idea to make binutils check for ABI
> incompatibilities at static link time, using GNU object attributes, which
> GCC should generate based on the ABI selected when compiling. See how
> powerpc and mips handle this, for example. That helps protect against
> user mistakes (linking .o files for different ABIs together) by making the
> linker complain about such mixing.
OK. I'll try to add some check here.
> The Argument Passing section of the ABI document you provided doesn't seem
> to say anything about the different argument passing for hard float, so I
> think you need to update the document to cover that issue (likewise for
> return values if they are handled differently for hard float). (And the
> table in 2.2.1.2 would presumably also need to say what's used for
> argument passing.)
OK. We will update it.
> We want the build-many-glibcs.py build to succeed. You'll need to
> investigate why you see this problem. The -profile option is defined in
> gcc/config/gnu-user.opt which all *-linux* targets should be using, so
> you'll need to look at why you get an error there.
>
> > > > 5. The following cases fail due to gcc optimize change the sequence of
> > > > -a * b to -(a * b) and got 1ulps error.
> > > > math/test-double-tgamma
> > > > math/test-float-tgamma
> > > > math/test-float32-tgamma
> > > > math/test-float32x-tgamma
> > > > math/test-float64-tgamma
> > > > math/test-ldouble-tgamma
>
> No, you just need to get a fix for the problem checked in upstream; no
> need to file a bug in GCC Bugzilla.
OK. My colleague Xianmiao Qu is working on these problems, will be fixed soon.
Thanks,
Han Mao
next prev parent reply other threads:[~2018-09-18 6:22 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 2:56 Mao Han
[not found] ` <cover.1536720821.git.han_mao@c-sky.com>
2018-09-12 2:56 ` [PATCH v4 01/13] C-SKY: ABI related code Mao Han
2018-09-12 4:16 ` H.J. Lu
2018-09-12 7:07 ` Mao Han
2018-09-12 8:23 ` Florian Weimer
2018-09-12 9:06 ` Mao Han
2018-09-29 1:46 ` Palmer Dabbelt
2018-09-30 9:04 ` Manuel A. Fernandez Montecelo
2018-10-01 8:18 ` Richard W.M. Jones
2018-09-17 21:46 ` Joseph Myers
2018-09-18 6:09 ` Mao Han
2018-09-12 2:56 ` [PATCH v4 05/13] C-SKY: Linux Syscall Interface Mao Han
2018-09-12 2:56 ` [PATCH v4 02/13] C-SKY: TLS support Mao Han
2018-09-12 2:56 ` [PATCH v4 03/13] C-SKY: Math support Mao Han
2018-09-17 21:49 ` Joseph Myers
2018-09-18 6:05 ` Mao Han
2018-09-12 2:57 ` [PATCH v4 13/13] C-SKY: Skeleton documentation Mao Han
2018-09-12 2:57 ` [PATCH v4 06/13] C-SKY: Linux ABI Mao Han
2018-09-12 13:40 ` Arnd Bergmann
2018-09-12 14:21 ` Joseph Myers
2018-09-12 15:34 ` Arnd Bergmann
2018-09-12 21:28 ` struct elf_prstatus and Y2038 (was: Re: [PATCH v4 06/13] C-SKY: Linux ABI) Florian Weimer
2018-09-13 10:48 ` Arnd Bergmann
2018-09-13 10:56 ` struct elf_prstatus and Y2038 Florian Weimer
2018-09-13 8:17 ` [PATCH v4 06/13] C-SKY: Linux ABI Mao Han
2018-09-13 8:46 ` Arnd Bergmann
2018-09-13 15:32 ` [gnu-csky] " Joseph Myers
2018-09-13 16:35 ` Joseph Myers
2018-09-13 20:47 ` Arnd Bergmann
2018-09-13 20:59 ` Joseph Myers
2018-09-13 21:32 ` Arnd Bergmann
2018-09-13 22:57 ` Joseph Myers
2018-09-13 20:31 ` Arnd Bergmann
2018-09-13 20:49 ` Joseph Myers
2018-09-13 21:38 ` Arnd Bergmann
2018-09-12 2:57 ` [PATCH v4 08/13] C-SKY: Linux Startup and Dynamic Loading Code Mao Han
2018-09-12 2:57 ` [PATCH v4 12/13] C-SKY: Add build-many-glibcs.py support Mao Han
2018-09-12 2:57 ` [PATCH v4 11/13] C-SKY: Add ABI definitions in config.h.in Mao Han
2018-09-12 2:57 ` [PATCH v4 09/13] C-SKY: Add dynamic relocations to elf.h Mao Han
2018-09-12 3:05 ` [PATCH v4 04/13] C-SKY: NPTL support and Atomic Mao Han
2018-09-12 3:05 ` [PATCH v4 07/13] C-SKY: ABI Lists Mao Han
2018-09-12 6:51 ` Andreas Schwab
2018-09-12 7:12 ` Mao Han
2018-09-12 12:35 ` Joseph Myers
2018-09-12 13:46 ` Andreas Schwab
2018-09-12 15:19 ` Joseph Myers
2018-09-13 8:23 ` Mao Han
2018-09-12 3:05 ` [PATCH v4 10/13] C-SKY: Build Infastructure Mao Han
2018-09-17 21:52 ` Joseph Myers
2018-09-18 6:02 ` Mao Han
2018-09-12 3:05 ` [PATCH 1/1] Update config.guess and config.sub to current versions Mao Han
2018-09-12 12:31 ` [PATCH v4 00/13] port C-SKY to glibc Joseph Myers
2018-09-13 8:14 ` Mao Han
2018-09-13 12:36 ` Joseph Myers
2018-09-18 6:22 ` Mao Han [this message]
2018-09-18 7:18 ` Mao Han
2018-09-18 11:43 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180918062209.GD3355@vmh-VirtualBox \
--to=han_mao@c-sky.com \
--cc=c-sky_gcc_upstream@c-sky.com \
--cc=gnu-csky@mentor.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).