From: Albert ARIBAUD <albert.aribaud@3adev.fr>
To: Joseph Myers <joseph@codesourcery.com>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Y2038: add struct __timespec64
Date: Tue, 25 Sep 2018 19:44:00 -0000 [thread overview]
Message-ID: <20180925214425.390377a9@athena> (raw)
In-Reply-To: <alpine.DEB.2.21.1809191455540.26757@digraph.polyomino.org.uk>
Hi Joseph,
On Wed, 19 Sep 2018 15:00:33 +0000, Joseph Myers
<joseph@codesourcery.com> wrote :
> On Wed, 19 Sep 2018, Joseph Myers wrote:
>
> > The bit-fields needs to be *anonymous* for initializers to work as
> > intended. It can't have the name tv_pad that it has in this patch, or any
> > other name, with our without leading underscores.
>
> Ignore this, I see you are distinguishing between an internal type here
> with a named field and a public type with an anonymous field.
Indeed I am, and rather than ignoring your remark, I'll take it as a
sign that my comment is possibly confusing and needs to make it
explicit that there are two types, one private to glibc and one public.
> *But* I wouldn't expect the internal type to be declared in any public
> header at all. That is, this should not be a bits/ header at all, not an
> installed header, because it would only be used in implementation code,
> not from any public interface. So you need to rename the header out of
> the bits/ namespace, which is purely for installed headers, and remove all
> the #includes from installed headers.
Ok.
> Regarding the comment you have on this type: 2038, not 2036; things, not
> tings; don't reference timeval at all (describing timespec in terms of
> timeval is a very historical way of writing a comment, that may have made
> sense when timeval was the established type and timespec was the new one,
> but doesn't make sense for over 20 years now; rather, comments on timeval
> should describe it as a legacy type, superseded by timespec).
Will fix.
Cordialement,
Albert ARIBAUD
3ADEV
next prev parent reply other threads:[~2018-09-25 19:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 7:27 Albert ARIBAUD (3ADEV)
2018-09-19 13:12 ` Joseph Myers
2018-09-19 14:55 ` Joseph Myers
2018-09-26 10:03 ` Albert ARIBAUD
2018-09-19 15:01 ` Joseph Myers
2018-09-25 19:44 ` Albert ARIBAUD [this message]
2018-09-19 16:25 ` Joseph Myers
2018-09-26 11:24 ` Albert ARIBAUD
2018-09-26 16:28 ` Joseph Myers
2018-10-17 10:28 ` Albert ARIBAUD
2018-10-17 12:18 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180925214425.390377a9@athena \
--to=albert.aribaud@3adev.fr \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).