* Do not clobber sp in _hurd_stack_setup
@ 2018-12-13 18:09 Joseph Myers
2018-12-14 0:20 ` Samuel Thibault
0 siblings, 1 reply; 2+ messages in thread
From: Joseph Myers @ 2018-12-13 18:09 UTC (permalink / raw)
To: libc-alpha; +Cc: samuel.thibault
GCC mainline now gives errors for an asm that clobbers the stack
pointer. According to
<https://gcc.gnu.org/ml/gcc-patches/2018-12/msg00932.html> GCC
previously ignored such a clobber; thus, this patch removes it from
_hurd_stack_setup.
Tested with build-many-glibcs.py for i686-gnu.
2018-12-13 Joseph Myers <joseph@codesourcery.com>
* sysdeps/mach/hurd/i386/init-first.c (_hurd_stack_setup): Do not
clobber sp.
diff --git a/sysdeps/mach/hurd/i386/init-first.c b/sysdeps/mach/hurd/i386/init-first.c
index f8ad2ceb8e..e3d5797266 100644
--- a/sysdeps/mach/hurd/i386/init-first.c
+++ b/sysdeps/mach/hurd/i386/init-first.c
@@ -361,7 +361,7 @@ _hurd_stack_setup (void)
*--data = caller;
asm volatile ("movl %0, %%esp\n" /* Switch to new outermost stack. */
"movl $0, %%ebp\n" /* Clear outermost frame pointer. */
- "jmp *%1" : : "r" (data), "r" (&doinit1) : "sp");
+ "jmp *%1" : : "r" (data), "r" (&doinit1));
/* NOTREACHED */
}
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Do not clobber sp in _hurd_stack_setup
2018-12-13 18:09 Do not clobber sp in _hurd_stack_setup Joseph Myers
@ 2018-12-14 0:20 ` Samuel Thibault
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Thibault @ 2018-12-14 0:20 UTC (permalink / raw)
To: Joseph Myers; +Cc: libc-alpha
Joseph Myers, le jeu. 13 déc. 2018 18:09:21 +0000, a ecrit:
> GCC mainline now gives errors for an asm that clobbers the stack
> pointer. According to
> <https://gcc.gnu.org/ml/gcc-patches/2018-12/msg00932.html> GCC
> previously ignored such a clobber; thus, this patch removes it from
> _hurd_stack_setup.
Since the code does not return there is no use for a clobber anyway :)
Please commit, thanks!
> Tested with build-many-glibcs.py for i686-gnu.
>
> 2018-12-13 Joseph Myers <joseph@codesourcery.com>
>
> * sysdeps/mach/hurd/i386/init-first.c (_hurd_stack_setup): Do not
> clobber sp.
>
> diff --git a/sysdeps/mach/hurd/i386/init-first.c b/sysdeps/mach/hurd/i386/init-first.c
> index f8ad2ceb8e..e3d5797266 100644
> --- a/sysdeps/mach/hurd/i386/init-first.c
> +++ b/sysdeps/mach/hurd/i386/init-first.c
> @@ -361,7 +361,7 @@ _hurd_stack_setup (void)
> *--data = caller;
> asm volatile ("movl %0, %%esp\n" /* Switch to new outermost stack. */
> "movl $0, %%ebp\n" /* Clear outermost frame pointer. */
> - "jmp *%1" : : "r" (data), "r" (&doinit1) : "sp");
> + "jmp *%1" : : "r" (data), "r" (&doinit1));
> /* NOTREACHED */
> }
>
>
> --
> Joseph S. Myers
> joseph@codesourcery.com
>
--
Samuel
je n ai cité aucun message et sur irc on parle effectivement comme des
enfants de 5 ans na!
> 3. Quand tu cite un message, répond _après_ ce que tu cites !
-+- Yota in : Guide du Neuneu d'Usenet - A un Yota près c'était bon -+-
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-13 22:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-13 18:09 Do not clobber sp in _hurd_stack_setup Joseph Myers
2018-12-14 0:20 ` Samuel Thibault
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).