From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23040 invoked by alias); 14 Dec 2018 21:03:30 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 22911 invoked by uid 89); 14 Dec 2018 21:03:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 spammy=12PM, 12pm, Hx-languages-length:2010, austingroupbugsnet X-HELO: wp210.webpack.hosteurope.de Date: Fri, 14 Dec 2018 21:04:00 -0000 From: Jan =?iso-8859-1?Q?Kl=F6tzke?= To: Joseph Myers Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] Semaphores: add sem_timedwait_monotonic GNU extension [BZ #14717] Message-ID: <20181214210322.muknp5w6iy7cyczy@tuxedo> References: <20181213200009.22246-1-jan@kloetzke.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-HE-SMSGID: 1gXucF-0008KT-AP X-SW-Source: 2018-12/txt/msg00504.txt.bz2 On Thu, Dec 13, 2018 at 08:28:12PM +0000, Joseph Myers wrote: > On Thu, 13 Dec 2018, Jan Klötzke wrote: > > > The added sem_timedwait_monotonic() function behaves just like > > sem_timedwait() but is based on CLOCK_MONOTONIC. An identically named > > function is already provided by QNX for the same reasons. > > My understanding from the Austin Group discussion was that the preferred > approach was functions with "clock" instead of "timed" in their names, > taking a clockid parameter (so sem_clockwait in this case). > > http://austingroupbugs.net/view.php?id=1216 Oh, I wasn't aware of this proposal. Looks reasonable and even more generic. I will send a v2 accordingly. I'm not sure if I find the time to implement the other proposed functions but it looks worth it. > Note that new functions need a NEWS entry. They also need testcases; I > don't see any in this patch. Will fix that with v2 too. > How has this patch been tested? I'd have expected it to fail the ABI > tests, because > > > diff --git a/sysdeps/unix/sysv/linux/x86_64/64/libpthread.abilist b/sysdeps/unix/sysv/linux/x86_64/64/libpthread.abilist > > index 931c8277a8..a69993f4d9 100644 > > --- a/sysdeps/unix/sysv/linux/x86_64/64/libpthread.abilist > > +++ b/sysdeps/unix/sysv/linux/x86_64/64/libpthread.abilist > > @@ -254,3 +254,4 @@ GLIBC_2.4 pthread_mutexattr_getrobust_np F > > GLIBC_2.4 pthread_mutexattr_setprioceiling F > > GLIBC_2.4 pthread_mutexattr_setprotocol F > > GLIBC_2.4 pthread_mutexattr_setrobust_np F > > +GLIBC_2.29 sem_timedwait_monotonic F > > (for example) is not placing the new entry in its correct (LC_ALL=C) > sorted location. The cold and harsh truth is that I forgot to execute the tests. My bad. I only tested it by running some manual tests with the new version. > Are you covered by an FSF copyright assignment? Not yet. Quite frankly I'm a bit lost what needs to be done exactly to pass the legal part. Regards, Jan