From: Aurelien Jarno <aurelien@aurel32.net>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 1/5] m68k: Fix sigaction kernel definition (BZ #23960)
Date: Sun, 16 Dec 2018 22:57:00 -0000 [thread overview]
Message-ID: <20181216200651.GA3039@aurel32.net> (raw)
In-Reply-To: <f5612cdf-665c-3c11-2a51-4d8712b51ff9@linaro.org>
Hi,
On 2018-12-12 16:52, Adhemerval Zanella wrote:
>
>
> On 12/12/2018 08:41, Andreas Schwab wrote:
> > On Dez 12 2018, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:
> >
> >> The m68k kernel does define SA_RESTORER on arch/m68k/include/asm/signal.h
> >> (__ARCH_HAS_SA_RESTORER),
> >
> > These are not the same. The latter only tells <linux/signal_types.h> to
> > add the sa_restorer member, independent of SA_RESTORER (which m68k
> > doesn't define).
> >
> >> but the only difference it makes for m68k is at flush_signal_handlers
> >> where kernel sets the sa_restorer to NULL. So it indeed should be safe
> >> to just use default kernel_sigaction.h (I don't see any signal test
> >> issues). Updated patch below.
> >
> > This fails to add the sa_restorer member, causing the signal mask to be
> > mishandled.
> >
> > Andreas.
> >
>
> Updated patch below.
>
> --
>
> [BZ #23960]
> * sysdeps/unix/sysv/linux/kernel_sigaction.h (HAS_SA_RESTORER):
> Define if SA_RESTORER is defined.
> (kernel_sigaction): Define sa_restorer if HAS_SA_RESTORER is defined.
> (SET_SA_RESTORER, RESET_SA_RESTORER): Define iff the macro are not
> already defined.
> * sysdeps/unix/sysv/linux/m68k/kernel_sigaction.h (SA_RESTORER,
> kernel_sigaction, SET_SA_RESTORER, RESET_SA_RESTORER): Remove
> definitions.
> (HAS_SA_RESTORER): Define.
> * sysdeps/unix/sysv/linux/sparc/kernel_sigaction.h (SA_RESTORER,
> SET_SA_RESTORER, RESET_SA_RESTORER): Remove definition.
> (HAS_SA_RESTORER): Define.
> * sysdeps/unix/sysv/linux/nios2/kernel_sigaction.h: Include generic
> kernel_sigaction after define SET_SA_RESTORER and RESET_SA_RESTORER.
> * sysdeps/unix/sysv/linux/powerpc/kernel_sigaction.h: Likewise.
> * sysdeps/unix/sysv/linux/s390/kernel_sigaction.h: Likewise.
> * sysdeps/unix/sysv/linux/x86_64/sigaction.c: Likewise.
[ snip ]
> diff --git a/sysdeps/unix/sysv/linux/s390/kernel_sigaction.h b/sysdeps/unix/sysv/linux/s390/kernel_sigaction.h
> index 7a6a2c4f29..14f44c200b 100644
> --- a/sysdeps/unix/sysv/linux/s390/kernel_sigaction.h
> +++ b/sysdeps/unix/sysv/linux/s390/kernel_sigaction.h
> @@ -30,3 +30,5 @@ struct kernel_sigaction
> (kact)->sa_restorer = (act)->sa_restorer
> #define RESET_SA_RESTORER(act, kact) \
> (act)->sa_restorer = (kact)->sa_restorer
> +
> +#include <sysdeps/unix/sysv/linux/kernel_sigaction.h>
This is not correct, you should also remove struct kernel_sigaction from
this file, like it was done in the initial version of the patchset
(patch 5).
Aurelien
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2018-12-16 20:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 19:56 Adhemerval Zanella
2018-12-11 19:56 ` [PATCH 3/5] hppa: Remove kernel_sigaction.h Adhemerval Zanella
2018-12-18 18:28 ` Adhemerval Zanella
2018-12-11 19:56 ` [PATCH 4/5] ia64: " Adhemerval Zanella
2018-12-18 18:29 ` Adhemerval Zanella
2018-12-11 19:56 ` [PATCH 5/5] s390: Use generic kernel_sigaction.h Adhemerval Zanella
2018-12-18 18:44 ` Adhemerval Zanella
2018-12-11 20:09 ` [PATCH 2/5] alpha: Use Linux generic sigaction implementation Adhemerval Zanella
2018-12-18 18:28 ` Adhemerval Zanella
2018-12-11 22:47 ` [PATCH 1/5] m68k: Fix sigaction kernel definition (BZ #23960) Andreas Schwab
2018-12-12 10:41 ` Adhemerval Zanella
2018-12-12 10:44 ` Andreas Schwab
2018-12-12 19:01 ` Adhemerval Zanella
2018-12-14 18:43 ` Andreas Schwab
2018-12-16 22:57 ` Aurelien Jarno [this message]
2018-12-17 12:06 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181216200651.GA3039@aurel32.net \
--to=aurelien@aurel32.net \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).