From: "Andreas K. Hüttel" <dilfridge@gentoo.org>
To: libc-alpha@sourceware.org
Cc: "Andreas K. Hüttel" <dilfridge@gentoo.org>
Subject: [PATCH] resolv: AAAA (28) is valid, no fallthrough to default
Date: Thu, 10 Jan 2019 00:17:00 -0000 [thread overview]
Message-ID: <20190110001717.25717-1-dilfridge@gentoo.org> (raw)
The test resolv/tst-resolv-ai_idn-nolibidn2 kept failing, with the puzzling
output "invalid qtype: 28". Puzzling since 28 is an AAAA record.
Turns out the switch statement is missing a break, so the "T_AAAA" case
continues with "default".
---
resolv/tst-resolv-ai_idn-common.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/resolv/tst-resolv-ai_idn-common.c b/resolv/tst-resolv-ai_idn-common.c
index bb81c2ca23..61cc81b71f 100644
--- a/resolv/tst-resolv-ai_idn-common.c
+++ b/resolv/tst-resolv-ai_idn-common.c
@@ -241,6 +241,7 @@ response (const struct resolv_response_context *ctx,
qname[0] };
resolv_response_add_data (b, &addr, sizeof (addr));
}
+ break;
default:
FAIL_EXIT1 ("invalid qtype: %d", qtype);
}
--
2.20.1
next reply other threads:[~2019-01-10 0:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 0:17 Andreas K. Hüttel [this message]
2019-01-10 11:01 ` Florian Weimer
2019-01-10 13:47 ` Andreas K. Huettel
2019-01-10 13:51 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190110001717.25717-1-dilfridge@gentoo.org \
--to=dilfridge@gentoo.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).