From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128075 invoked by alias); 10 Jan 2019 00:46:02 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 120631 invoked by uid 89); 10 Jan 2019 00:46:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=H*Ad:D*jp X-HELO: mail.linet.jp Message-Id: <201901100043.AA04166@tamuki.linet.gr.jp> Date: Thu, 10 Jan 2019 00:46:00 -0000 To: Rafal Luzynski , libc-alpha@sourceware.org Cc: Siddhesh Poyarekar Subject: Re: [PATCH v5 1/5] strftime: Add missing uses of L_ macro, etc. [BZ #23758] From: TAMUKI Shoichi In-Reply-To: <553127895.95059.1547028145705@poczta.nazwa.pl> References: <553127895.95059.1547028145705@poczta.nazwa.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2019-01/txt/msg00220.txt.bz2 Hello Rafal, From: Rafal Luzynski Subject: Re: [PATCH v5 1/5] strftime: Add missing uses of L_ macro, etc. [BZ #23758] Date: Wed, 9 Jan 2019 11:02:25 +0100 (CET) > 1. Please remove any reference to [BZ #23758] from this patch > because it is not related with the bug. The changes are minor > and not visible for the users therefore they don't need any > Bugzilla report, documentation, etc. OK. I will do that as an independent patch. > 2. Regarding the subject of this email, which is also the first > line of the commit message, I would write something like this: > > "strftime: Consequently use the "L_" macro with character literals." > > As always, I am not a native speaker so other people may provide > better hints. Thank you. > > At first, make an unrelated changes for the consistency. > > If it is the part of the commit message then something like: > > "Make unrelated changes for the consistency." > > (The core problem is that "an" is incorrect for plural numbers.) Thank you. Also, "At first" is also incorrect, should be "First" (or "First of all"). But I will not add any of them this time because of an independent patch. > > ChangeLog: > > > > [BZ #23758] > > * time/strftime_l.c (__strftime_internal): Add missing uses of L_ > > macro, also add a missing space after the cast of _NL_CURRENT. > > Good but again, Bugzilla mention should be removed and "missing > uses" seems incorrect to me, "Add "L_" macros" or "Use "L_" macros" > is sufficient and seems correct to me. OK. I will correct in the next patch. Regards, TAMUKI Shoichi