From: Rich Felker <dalias@libc.org>
To: Torvald Riegel <triegel@redhat.com>
Cc: kemi <kemi.wang@intel.com>, "H.J. Lu" <hjl.tools@gmail.com>,
Ma Ling <ling.ma.program@gmail.com>,
GNU C Library <libc-alpha@sourceware.org>,
"Lu, Hongjiu" <hongjiu.lu@intel.com>,
"ling.ma" <ling.ml@antfin.com>, Wei Xiao <wei3.xiao@intel.com>
Subject: Re: [PATCH] NUMA spinlock [BZ #23962]
Date: Tue, 15 Jan 2019 16:44:00 -0000 [thread overview]
Message-ID: <20190115164405.GG23599@brightrain.aerifal.cx> (raw)
In-Reply-To: <6eaaec4d0ae349eaf31de1239f27c01dc1f5b6a8.camel@redhat.com>
On Tue, Jan 15, 2019 at 01:36:56PM +0100, Torvald Riegel wrote:
> > But, that's not enough. When tunable is not the bottleneck, the simple busy-waiting
> > algorithm of current adaptive mutex is the major negative factor which degrades mutex
> > performance.
>
> Note that I'm not advocating for focusing on just the adaptive mutex type.
> IMO, adding this type was a mistake because whether to spin or not does not
> affect semantics of the mutexes. Performance hints shouldn't be done via a
> mutex' type, and all mutex implementations should consider to spin at least
> a little.
Strongly agreed that this was a mistake. This same sentiment is why I
don't like the nomenclature "NUMA spinlock". If there are semantic
differences from a normal spinlock, it should be named for the
semantics, not for the form of extreme performance tuning it does. If
there are no semantic differences, NUMA-optimized spinlock
implementation should just be a drop-in replacement for the standard
spinlock API.
Rich
next prev parent reply other threads:[~2019-01-15 16:44 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-26 9:51 Ma Ling
2019-01-03 4:05 ` 马凌(彦军)
[not found] ` <0a474516-b8c8-48cf-aeea-e57c77b78cbd.ling.ml@antfin.com>
2019-01-03 5:35 ` 转发:[PATCH] " 马凌(彦军)
2019-01-03 14:52 ` Szabolcs Nagy
2019-01-03 19:59 ` H.J. Lu
2019-01-05 12:34 ` [PATCH] " Carlos O'Donell
2019-01-05 16:36 ` H.J. Lu
2019-01-07 19:12 ` Florian Weimer
2019-01-07 19:49 ` H.J. Lu
2019-01-10 16:31 ` Carlos O'Donell
2019-01-10 16:32 ` Florian Weimer
2019-01-10 16:41 ` Carlos O'Donell
2019-01-10 17:52 ` Szabolcs Nagy
2019-01-10 19:24 ` Carlos O'Donell
2019-01-11 12:01 ` kemi
2019-01-14 22:45 ` Torvald Riegel
2019-01-15 9:32 ` Florian Weimer
2019-01-15 12:01 ` Torvald Riegel
2019-01-15 12:17 ` Florian Weimer
2019-01-15 12:31 ` Torvald Riegel
2019-01-11 16:24 ` H.J. Lu
2019-01-14 23:03 ` Torvald Riegel
2019-01-04 4:13 ` 转发:[PATCH] " 马凌(彦军)
2019-01-03 20:43 ` [PATCH] " Rich Felker
2019-01-03 20:55 ` H.J. Lu
2019-01-03 21:21 ` Rich Felker
2019-01-03 21:28 ` H.J. Lu
2019-01-14 23:18 ` Torvald Riegel
2019-01-15 2:33 ` kemi
2019-01-15 12:37 ` Torvald Riegel
2019-01-15 16:44 ` Rich Felker [this message]
2019-01-17 3:10 ` kemi
2019-02-04 17:23 ` Torvald Riegel
2019-01-14 22:40 ` Torvald Riegel
2019-01-14 23:26 ` Torvald Riegel
2019-01-15 4:47 ` 马凌(彦军)
2019-01-15 2:56 ` kemi
2019-01-15 4:27 ` 马凌(彦军)
2019-01-10 13:18 马凌(彦军)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190115164405.GG23599@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=hjl.tools@gmail.com \
--cc=hongjiu.lu@intel.com \
--cc=kemi.wang@intel.com \
--cc=libc-alpha@sourceware.org \
--cc=ling.ma.program@gmail.com \
--cc=ling.ml@antfin.com \
--cc=triegel@redhat.com \
--cc=wei3.xiao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).