From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84483 invoked by alias); 17 Jan 2019 06:31:48 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 84360 invoked by uid 89); 17 Jan 2019 06:31:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=month, dating, balance, day X-HELO: mail.linet.jp Message-Id: <201901170627.AA04183@tamuki.linet.gr.jp> From: TAMUKI Shoichi Date: Thu, 17 Jan 2019 06:31:00 -0000 To: Zack Weinberg Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v6 1/2] strftime: Set the default width of "%Ey" to 2 [BZ #23758] In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2019-01/txt/msg00428.txt.bz2 Hello Zack, Thank you for reviewing my patch's documentation and commit messages. Almost all the things I wanted to say were expressed and I think that is very nice. Also, Rafal and Paul, thank you for reviewing my patch's documentation and commit messages. I will soon prepare a new version set of patches with these remarks applied. From: Zack Weinberg Subject: Re: [PATCH v6 1/2] strftime: Set the default width of "%Ey" to 2 [BZ #23758] Date: Wed, 16 Jan 2019 11:17:09 -0500 > > The Japanese era name is scheduled to be changed on May 1, 2019. > > Prior to this, change the alternative representation for year in > > strftime to pad the number with zero to keep it constant width, so > > that prevent the trouble we saw in the past from becoming obvious > > again from the year after the era name changes onward. > > > > Since only one Japanese era name is used by each emperor's reign as > > lately, it is rare that the year ends in one digit or lasts more than > > three digits. In addition, the default width of month, day, hour, > > minute, and second is 2, so adjust the default width of year the same > > as them, and then the whole display balance is improved. Therefore, > > it would be reasonable to set the default width padding with zero of > > "%Ey" to 2. > > This commit message will not be clear to readers who are not familiar > with Japanese era dating. I had to look it up myself. It also needs > to make clear that %Ey is changed for all locales, not just Japanese > locales, and this is expected to be harmless for locales that use %Ey > for something else. (I see you mentioned this in the commit message > for the %EY change, but it belongs here.) > > Based on what I learned, I suggest this instead: > > | In Japanese locales, strftime's alternative year format (%Ey) > | produces the year of the current era (neng?). A new era typically > | begins when a new emperor is enthroned. The year of the current > | era is therefore usually a one- or two-digit number. I'm sorry, but I did not understand the meaning of (neng?). I will rewrite it to (Japanese Calendar) tentatively. Regards, TAMUKI Shoichi