From: TAMUKI Shoichi <tamuki@linet.gr.jp>
To: Rafal Luzynski <digitalfreak@lingonborough.com>,
libc-alpha@sourceware.org
Subject: Re: [PATCH v6 1/2] strftime: Set the default width of "%Ey" to 2 [BZ #23758]
Date: Fri, 18 Jan 2019 14:01:00 -0000 [thread overview]
Message-ID: <201901181358.AA04192@tamuki.linet.gr.jp> (raw)
In-Reply-To: <1340798999.404367.1547748713395@poczta.nazwa.pl>
Hello Rafal,
From: Rafal Luzynski <digitalfreak@lingonborough.com>
Subject: Re: [PATCH v7 1/2] strftime: Set the default width of "%Ey" to 2 [BZ #23758]
Date: Thu, 17 Jan 2019 19:11:53 +0100 (CET)
> > In Japanese locales, strftime's alternative year format (%Ey) produces
> > the year of the current era (Japanese calendar).
>
> As I wrote in my previous email, the term "Japanese calendar" may be
> incorrect here.
I think that (Japanese numeric era year) would be more appropriate.
> Now I can see that neither of our comments may be correct. "%Ey" produces
> the number of the year within the current era. It says which (numbered)
> year of the current era is now. Is "nengo" a correct name for this?
> Should we maybe drop this parentheses completely, including its content?
Not correct, "nengo" (or "gengo") means "era name" (%EC). So, We may
rather drop this parentheses completely.
> I don't quote the rest of your patch here as it looks correct to me,
> looking at previous comments from Zack and Paul. Please rethink this
> minor issue in the commit message and/or maybe let's wait for Zack's
> or Paul's comment about it and it will be OK for me to commit this.
OK, I am going to rethink the minor issue including the quote issue.
I will try to match existing sentences as much as possible.
Regards,
TAMUKI Shoichi
next prev parent reply other threads:[~2019-01-18 14:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 6:36 [PATCH v7 0/2] strftime: Improve the width of alternative representation for year [BZ #23758][BZ #24096] TAMUKI Shoichi
2019-01-17 6:38 ` [PATCH v7 1/2] strftime: Set the default width of "%Ey" to 2 [BZ #23758] TAMUKI Shoichi
2019-01-17 18:13 ` Rafal Luzynski
2019-01-18 14:01 ` TAMUKI Shoichi [this message]
2019-01-17 6:40 ` [PATCH v7 2/2] strftime: Pass the additional flags from "%EY" to "%Ey" [BZ #24096] TAMUKI Shoichi
2019-01-17 18:45 ` Rafal Luzynski
-- strict thread matches above, loose matches on Subject: below --
2019-01-11 4:48 [PATCH v6 0/2] strftime: Improve the width of alternative representation for year [BZ #23758] TAMUKI Shoichi
2019-01-11 4:50 ` [PATCH v6 1/2] strftime: Set the default width of "%Ey" to 2 " TAMUKI Shoichi
2019-01-16 16:17 ` Zack Weinberg
2019-01-17 6:31 ` TAMUKI Shoichi
2019-01-17 17:57 ` Rafal Luzynski
2019-01-18 2:46 ` Zack Weinberg
2019-01-18 14:01 ` TAMUKI Shoichi
2019-01-18 18:35 ` Rafal Luzynski
2019-01-18 14:01 ` TAMUKI Shoichi
2019-01-18 18:44 ` Rafal Luzynski
2019-01-19 3:52 ` TAMUKI Shoichi
2019-01-19 17:08 ` Zack Weinberg
2019-01-19 21:42 ` Rafal Luzynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201901181358.AA04192@tamuki.linet.gr.jp \
--to=tamuki@linet.gr.jp \
--cc=digitalfreak@lingonborough.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).