public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Stepan Golosunov <stepan@golosunov.pp.ru>
To: Lukasz Majewski <lukma@denx.de>
Cc: Joseph Myers <joseph@codesourcery.com>,
	libc-alpha@sourceware.org, Arnd Bergmann <arnd@arndb.de>,
	Paul Eggert <eggert@cs.ucla.edu>
Subject: Re: [PATCH v2 2/7] y2038: Introduce __ASSUME_64BIT_TIME define
Date: Tue, 30 Apr 2019 21:48:00 -0000	[thread overview]
Message-ID: <20190430214748.rzjlcu3f3hdyqnhw@sghpc.golosunov.pp.ru> (raw)
In-Reply-To: <20190430110505.2a0c7d1a@jawa>

30.04.2019 ц≈ 11:05:05 +0200 Lukasz Majewski ц▌ц│ц░ц┴ц⌠ц│ц▄:
> #if __TIMESIZE != 64
> # if __LINUX_KERNEL_VERSION >= 0x050100
> #  define __ASSUME_64BIT_TIME 1
> # endif
> #endif

I think __WORDSIZE would be more appropriate here than __TIMESIZE.


> IMHO, the abstraction would be:
> 
> 1. The __ASSUME_64BIT_TIME is _never_ defined for 64 bit native systems
> 
> 2. It is defined by default in:
> sysdeps/unix/sysv/linux/kernel-features.h for 32 bit systems (and the
> actual presence of the syscall is decided upon definitions of __NR_xxx*
> (i.e. # ifdef __NR_clock_settime64).

I think that __NR_clock_settime64 should be used unconditionally when
__ASSUME_64BIT_TIME is defined.

(__ASSUME_TIME64_SYSCALLS would probably be better name.)


> As those syscalls are provided on almost every 32 bit system now
> (5.1-rc6):
> git grep -n "clock_settime64"
> 
> gives support for: arm, arm64 (compat mode), m68k, microblaze, mips,
> parisc, powerpc, s390, sh, sparc, x86, xtensa
> 
> So it would be reasonable to just add this __ASSUME definition code to
> sysdeps/unix/sysv/linux/kernel-features.h and #undef it for
> architectures not supporting it (i.e. c-sky and riscv).

I believe that the only 32-bit architecture without
__NR_clock_settime64 is x32.  While newer 32-bit architectures like
riscv do not have __NR_clock_settime:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d4c08b9776b392e20efc6198ebe1bc8ec1911d9b

  reply	other threads:[~2019-04-30 21:47 UTC|newest]

Thread overview: 111+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-14 23:36 [PATCH 0/6] y2038: Linux: Provide __clock_* functions supporting 64 bit time Lukasz Majewski
2019-04-14 22:09 ` [PATCH 6/6] y2038: linux: Provide __clock_nanosleep64 implementation Lukasz Majewski
2019-04-17 22:22   ` Joseph Myers
2019-04-18  6:17     ` Lukasz Majewski
2019-04-14 22:09 ` [PATCH 5/6] y2038: linux: Provide __clock_gettime64 implementation Lukasz Majewski
2019-04-14 22:09 ` [PATCH 4/6] y2038: linux: Provide __clock_getres64 implementation Lukasz Majewski
2019-04-14 22:09 ` [PATCH 3/6] y2038: linux: Provide __clock_settime64 implementation Lukasz Majewski
2019-04-17 22:11   ` Joseph Myers
2019-04-18 11:09     ` Lukasz Majewski
2019-04-20 11:21   ` Stepan Golosunov
2019-04-21 11:41     ` Lukasz Majewski
2019-04-22 16:25       ` Stepan Golosunov
2019-04-23 10:43         ` Arnd Bergmann
2019-04-23 16:08           ` Lukasz Majewski
2019-04-14 22:09 ` [PATCH 2/6] y2038: Provide conversion helpers for struct __timespec64 Lukasz Majewski
2019-04-14 22:09 ` [PATCH 1/6] y2038: Introduce internal for glibc " Lukasz Majewski
2019-04-29 10:46 ` [PATCH v2 0/7] y2038: Linux: Provide __clock_* functions supporting 64 bit time Lukasz Majewski
2019-04-29 10:46   ` [PATCH v2 2/7] y2038: Introduce __ASSUME_64BIT_TIME define Lukasz Majewski
2019-04-30  1:27     ` Joseph Myers
2019-04-30 11:10       ` Lukasz Majewski
2019-04-30 21:48         ` Stepan Golosunov [this message]
2019-05-02  8:51           ` Lukasz Majewski
2019-05-02 11:55             ` Stepan Golosunov
2019-05-02 13:56               ` Lukasz Majewski
2019-05-06 13:38                 ` Lukasz Majewski
2019-05-06 14:27                   ` Lukasz Majewski
2019-05-06 19:36                     ` Stepan Golosunov
2019-05-06 21:15                       ` Lukasz Majewski
2019-05-07 20:04                         ` Stepan Golosunov
2019-05-07 20:44                           ` Joseph Myers
2019-05-08  7:51                           ` Lukasz Majewski
2019-05-08 19:48                             ` Stepan Golosunov
2019-05-09 16:12                               ` Joseph Myers
2019-05-16  4:01                               ` Arnd Bergmann
2019-05-16 19:54                                 ` Stepan Golosunov
2019-05-16 20:00                                 ` Joseph Myers
2019-05-17  7:23                                   ` Florian Weimer
2019-05-17  8:34                                     ` Arnd Bergmann
2019-05-07 15:44                       ` Joseph Myers
2019-05-02 15:04         ` Joseph Myers
2019-05-05 14:11           ` Stepan Golosunov
2019-05-05 20:46             ` Lukasz Majewski
2019-05-06 14:56           ` Lukasz Majewski
2019-05-07 15:35             ` Joseph Myers
2019-05-08 10:18               ` Lukasz Majewski
2019-05-09 15:46                 ` Joseph Myers
2019-05-15 15:39                   ` Lukasz Majewski
2019-05-16  3:57                     ` Arnd Bergmann
2019-05-16  6:59                       ` Lukasz Majewski
2019-05-31 11:38                 ` Stepan Golosunov
2019-06-05 16:35                   ` Lukasz Majewski
2019-06-06  6:50                     ` Stepan Golosunov
2019-04-29 10:46   ` [PATCH v2 1/7] y2038: Introduce internal for glibc struct __timespec64 Lukasz Majewski
2019-04-29 10:46   ` [PATCH v2 5/7] y2038: linux: Provide __clock_getres64 implementation Lukasz Majewski
2019-04-29 10:46   ` [PATCH v2 3/7] y2038: Provide conversion helpers for struct __timespec64 Lukasz Majewski
2019-05-02 11:56     ` Stepan Golosunov
2019-05-02 14:17       ` Lukasz Majewski
2019-05-02 15:59         ` Joseph Myers
2019-05-02 16:19           ` Lukasz Majewski
2019-04-29 10:46   ` [PATCH v2 4/7] y2038: linux: Provide __clock_settime64 implementation Lukasz Majewski
2019-04-29 10:46   ` [PATCH v2 6/7] y2038: linux: Provide __clock_gettime64 implementation Lukasz Majewski
2019-04-29 12:13   ` [PATCH v2 7/7] y2038: linux: Provide __clock_nanosleep64 implementation Lukasz Majewski
2019-05-07 13:19 ` [PATCH v3 0/5] y2038: Linux: Provide __clock_settime function supporting 64 bit time Lukasz Majewski
2019-05-07 13:19   ` [PATCH v3 1/5] y2038: Introduce __ASSUME_TIME64_SYSCALLS define Lukasz Majewski
2019-05-07 16:04     ` Joseph Myers
2019-05-07 13:19   ` Lukasz Majewski
2019-05-07 13:19   ` [PATCH v3 0/5] y2038: Linux: Provide __clock_settime function supporting 64 bit time Lukasz Majewski
2019-05-07 13:19   ` [PATCH v3 3/5] y2038: Provide conversion helpers for struct __timespec64 Lukasz Majewski
2019-05-07 13:19   ` [PATCH v3 2/5] y2038: Introduce internal for glibc " Lukasz Majewski
2019-05-07 13:30     ` Andreas Schwab
2019-05-07 14:07       ` Lukasz Majewski
2019-05-07 14:13         ` Andreas Schwab
2019-05-08  8:32           ` Lukasz Majewski
2019-05-08  8:38             ` Andreas Schwab
2019-05-08  9:10               ` Lukasz Majewski
2019-05-08  9:12                 ` Andreas Schwab
2019-05-08  9:38                   ` Lukasz Majewski
2019-05-07 13:19   ` [PATCH v3 5/5] y2038: Support for Y2038 safe time on 32 bit systems Lukasz Majewski
2019-05-07 16:37     ` Joseph Myers
2019-05-08 10:27       ` Lukasz Majewski
2019-05-07 13:19   ` Lukasz Majewski
2019-05-07 13:34     ` Andreas Schwab
2019-05-07 13:19   ` [PATCH v3 4/5] y2038: linux: Provide __clock_settime64 implementation Lukasz Majewski
2019-05-07 16:40     ` Joseph Myers
2019-05-07 13:19   ` [PATCH v3 3/5] y2038: Provide conversion helpers for struct __timespec64 Lukasz Majewski
2019-05-07 13:19   ` [PATCH v3 4/5] y2038: linux: Provide __clock_settime64 implementation Lukasz Majewski
2019-05-07 13:19   ` [PATCH v3 2/5] y2038: Introduce internal for glibc struct __timespec64 Lukasz Majewski
2019-05-08 15:56 ` [PATCH] y2038: Introduce __ASSUME_TIME64_SYSCALLS define Lukasz Majewski
2019-05-09 15:58   ` Joseph Myers
2019-05-09 16:18     ` Stepan Golosunov
2019-05-15 14:27 ` [PATCH v5] " Lukasz Majewski
2019-05-21 15:16   ` Lukasz Majewski
2019-05-23  7:34   ` Stepan Golosunov
2019-05-23  9:35     ` Lukasz Majewski
2019-05-25 16:20       ` Lukasz Majewski
2019-05-25 19:46       ` Stepan Golosunov
2019-05-26 12:39         ` Lukasz Majewski
2019-05-28 16:01           ` Lukasz Majewski
2019-05-28 19:53           ` Joseph Myers
2019-05-28 22:46             ` Lukasz Majewski
2019-05-28 22:50               ` Joseph Myers
2019-05-28 19:47         ` Joseph Myers
2019-05-28 22:09           ` Lukasz Majewski
2019-05-28 22:44             ` Joseph Myers
2019-05-23 21:18     ` Joseph Myers
2019-05-20 10:27 ` [PATCH v4 0/3] y2038: Linux: Provide __clock_settime64 function supporting 64 bit time Lukasz Majewski
2019-05-20 10:27   ` [PATCH v4 3/3] y2038: linux: Provide __clock_settime64 implementation Lukasz Majewski
2019-05-23  7:09     ` Stepan Golosunov
2019-05-23  9:28       ` Lukasz Majewski
2019-05-20 10:27   ` [PATCH v4 1/3] y2038: Introduce internal for glibc struct __timespec64 Lukasz Majewski
2019-05-20 10:27   ` [PATCH v4 2/3] y2038: Provide conversion helpers for " Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190430214748.rzjlcu3f3hdyqnhw@sghpc.golosunov.pp.ru \
    --to=stepan@golosunov.pp.ru \
    --cc=arnd@arndb.de \
    --cc=eggert@cs.ucla.edu \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=lukma@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).