From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45798 invoked by alias); 21 Oct 2019 01:55:57 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 45788 invoked by uid 89); 21 Oct 2019 01:55:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=gabriel, gomes, Gomes, Gabriel X-HELO: smtpout1.mo528.mail-out.ovh.net Date: Mon, 21 Oct 2019 01:55:00 -0000 From: "Gabriel F. T. Gomes" To: Subject: Re: [PATCH 19/31] Remove hidden_def and hidden_proto from cvt functions Message-ID: <20191020225542.1c515b89@tereshkova> In-Reply-To: <20191015190529.11559-20-gabriel@inconstante.net.br> References: <20191015190529.11559-1-gabriel@inconstante.net.br> <20191015190529.11559-20-gabriel@inconstante.net.br> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Ovh-Tracer-Id: 1164461980049460931 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrkeeggdehudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecu X-SW-Source: 2019-10/txt/msg00607.txt.bz2 On Tue, 15 Oct 2019, Gabriel F. T. Gomes wrote: > >Some *cvt functions are not called from within libc, yet they use >hidden_def and hidden_proto. This patch cleans this up and adds >attribute_hidden to the declarations, for architectures that need it. As I mentioned on a reply to Florian, I tested this patchset with build-many-glibcs.py and I found another error (besides the one that Florian pointed out). The error is caused by this patch (on at least s390x and alpha), but the patch is actually not needed, at all. :/ I'll send v2 without it and adapted for its absence. :)