* [PATCH v2] math: enhance the endloop condition of function handle_input_flag
@ 2019-10-23 11:13 liqingqing3
0 siblings, 0 replies; 2+ messages in thread
From: liqingqing3 @ 2019-10-23 11:13 UTC (permalink / raw)
To: libc-alpha; +Cc: hushiyuan
From: l00283554 <liqingqing3@huawei.com>
v2:
- sorry, update the topic, pls ingore the first email.
review the source code of function "handle_input_flag"
and found that the endloop condition is not correct, cause when the loop variable
" i " euqal to 16, then the input_flags[16] will be out of bounds. though I
think for now the inputs maybe all right, but just enhanced it.
---
math/gen-auto-libm-tests.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/math/gen-auto-libm-tests.c b/math/gen-auto-libm-tests.c
index f15af29a4e0..08684c4646d 100644
--- a/math/gen-auto-libm-tests.c
+++ b/math/gen-auto-libm-tests.c
@@ -1298,7 +1298,7 @@ handle_input_flag (char *arg, input_flag *flag,
char c = *ep;
*ep = 0;
bool found = false;
- for (input_flag_type i = flag_first_flag; i <= num_input_flag_types; i++)
+ for (input_flag_type i = flag_first_flag; i < num_input_flag_types; i++)
{
if (strcmp (arg, input_flags[i]) == 0)
{
--
2.23.0.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread* [PATCH v2] math: enhance the endloop condition of function handle_input_flag
@ 2019-10-24 12:20 liqingqing (C)
0 siblings, 0 replies; 2+ messages in thread
From: liqingqing (C) @ 2019-10-24 12:20 UTC (permalink / raw)
To: Florian Weimer; +Cc: libc-alpha, Hushiyuan
> I think the change looks good. Would you please resubmit it with a properly formatted commit message? Thanks.
Hi Florian, below is my second submit, I had updated the format message. hope to get any other suggestions.
https://sourceware.org/ml/libc-alpha/2019-10/msg00679.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-24 12:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-23 11:13 [PATCH v2] math: enhance the endloop condition of function handle_input_flag liqingqing3
2019-10-24 12:20 liqingqing (C)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).