From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118012 invoked by alias); 25 Oct 2019 15:36:56 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 117959 invoked by uid 89); 25 Oct 2019 15:36:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=H*F:D*br, HContent-Transfer-Encoding:8bit X-HELO: smtpout1.mo803.mail-out.ovh.net From: "Gabriel F. T. Gomes" To: Subject: [PATCH v2 27/30] Avoid compat symbols for totalorder in powerpc64le IEEE long double Date: Fri, 25 Oct 2019 15:37:00 -0000 Message-ID: <20191025153410.15405-28-gabriel@inconstante.net.br> In-Reply-To: <20191025153410.15405-1-gabriel@inconstante.net.br> References: <20191025153410.15405-1-gabriel@inconstante.net.br> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Ovh-Tracer-Id: 1626925369556651715 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrleefgdelvdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecu X-SW-Source: 2019-10/txt/msg00797.txt.bz2 From: "Gabriel F. T. Gomes" Changes since v1: - Added comment on the redefinition of libm_alias_float128_other_r_ldbl. -- 8< -- On powerpc64le, the libm_alias_float128_other_r_ldbl macro is used to create an alias between totalorderf128 and __totalorderlieee128, as well as between the totalordermagf128 and __totalordermaglieee128. However, the totalorder* and totalordermag* functions changed their parameter type since commit ID 42760d764649 and got compat symbols for their old versions. With this change, the aforementioned macro would create two conflicting aliases for __totalorderlieee128 and __totalordermaglieee128. This patch avoids the creation of the alias between the IEEE long double symbols (__totalorderl*ieee128) and the compat symbols, because the IEEE long double functions have never been exported thus don't need such compat symbol. --- sysdeps/ieee754/ldbl-128/s_totalorderl.c | 9 +++++++++ sysdeps/ieee754/ldbl-128/s_totalordermagl.c | 9 +++++++++ 2 files changed, 18 insertions(+) diff --git a/sysdeps/ieee754/ldbl-128/s_totalorderl.c b/sysdeps/ieee754/ldbl-128/s_totalorderl.c index 098bd2bcab..f9db06c025 100644 --- a/sysdeps/ieee754/ldbl-128/s_totalorderl.c +++ b/sysdeps/ieee754/ldbl-128/s_totalorderl.c @@ -74,6 +74,15 @@ __totalorder_compatl (_Float128 x, _Float128 y) { return __totalorderl (&x, &y); } +/* On platforms that reuse the _Float128 implementation for IEEE long + double (powerpc64le), the libm_alias_float128_other_r_ldbl macro + (which is called by the libm_alias_ldouble macro) is used to create + aliases between *f128 (_Float128 API) and __*ieee128 functions. + However, this compat version of totalorderl is older than the + availability of __ieee*128 symbols, thus, the compat alias is not + required, nor desired. */ +#undef libm_alias_float128_other_r_ldbl +#define libm_alias_float128_other_r_ldbl(from, to, r) #undef do_symbol #define do_symbol(orig_name, name, aliasname) \ strong_alias (orig_name, name) \ diff --git a/sysdeps/ieee754/ldbl-128/s_totalordermagl.c b/sysdeps/ieee754/ldbl-128/s_totalordermagl.c index b31788c77c..45b17ed4dd 100644 --- a/sysdeps/ieee754/ldbl-128/s_totalordermagl.c +++ b/sysdeps/ieee754/ldbl-128/s_totalordermagl.c @@ -68,6 +68,15 @@ __totalordermag_compatl (_Float128 x, _Float128 y) { return __totalordermagl (&x, &y); } +/* On platforms that reuse the _Float128 implementation for IEEE long + double (powerpc64le), the libm_alias_float128_other_r_ldbl macro + (which is called by the libm_alias_ldouble macro) is used to create + aliases between *f128 (_Float128 API) and __*ieee128 functions. + However, this compat version of totalordermagl is older than the + availability of __ieee*128 symbols, thus, the compat alias is not + required, nor desired. */ +#undef libm_alias_float128_other_r_ldbl +#define libm_alias_float128_other_r_ldbl(from, to, r) #undef do_symbol #define do_symbol(orig_name, name, aliasname) \ strong_alias (orig_name, name) \ -- 2.21.0