From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126260 invoked by alias); 27 Nov 2019 17:47:54 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 126251 invoked by uid 89); 27 Nov 2019 17:47:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=H*F:D*br X-HELO: smtpout1.mo528.mail-out.ovh.net Date: Wed, 27 Nov 2019 17:47:00 -0000 From: "Gabriel F. T. Gomes" To: Paul E Murphy CC: Subject: Re: [PATCH v2 18/30] ldbl-128ibm-compat: Add tests for strfroml, strtold, and wcstold Message-ID: <20191127144738.3f5b5086@tereshkova> In-Reply-To: <27a1e236-5146-2fc7-972b-5438a57c68f2@linux.ibm.com> References: <20191025153410.15405-1-gabriel@inconstante.net.br> <20191025153410.15405-19-gabriel@inconstante.net.br> <27a1e236-5146-2fc7-972b-5438a57c68f2@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Ovh-Tracer-Id: 13169932685328961080 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrudeihedguddtgecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjqdffgfeufgfipdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeffhffvuffkjghfofggtgfgihesthejredtredtvdenucfhrhhomhepfdfirggsrhhivghlucfhrdcuvfdrucfiohhmvghsfdcuoehgrggsrhhivghlsehinhgtohhnshhtrghnthgvrdhnvghtrdgsrheqnecukfhppedtrddtrddtrddtpddujeelrddukedvrdduheegrddutddtnecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopefgigegrdgvmhhprdhlohgtrghlpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpehgrggsrhhivghlsehinhgtohhnshhtrghnthgvrdgvthhirdgsrhdprhgtphhtthhopehlihgstgdqrghlphhhrgesshhouhhrtggvfigrrhgvrdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-SW-Source: 2019-11/txt/msg00904.txt.bz2 On Thu, 14 Nov 2019, Paul E Murphy wrote: >On 10/25/19 10:33 AM, Gabriel F. T. Gomes wrote: >> >> + if (read != (long double) -1) > >Trivial nit, any reason to avoid using -1.0L directly (likewise for >test-wcstold-ldbl-compat.c)? No reason, really. I applied this suggestion locally (in both files).