From: "Carlos O'Donell (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Florian Weimer <fweimer@redhat.com>, libc-alpha@sourceware.org
Subject: [review v5] Lazy binding failures during dlopen/dlclose must be fatal [BZ #24304]
Date: Wed, 27 Nov 2019 19:04:00 -0000 [thread overview]
Message-ID: <20191127190415.39EB220AF6@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1572549639000.I6b1addfe2e30f50a1781595f046f44173db9491a@gnutoolchain-gerrit.osci.io>
Carlos O'Donell has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/467
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
Additional news entry is OK (matches what Adhemerval is doing). Please feel free to split this out as a distinct commit if you like though. Otherwise it slows down this review.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
| --- NEWS
| +++ NEWS
| @@ -74,15 +74,21 @@ * The settimeofday function can still be used to set a system-wide time
| Note that settimeofday itself is obsolescent according to POSIX.
| Programs that set the system time should use clock_settime and/or
| the adjtime family of functions instead. We may also cease to make
| settimeofday available to newly linked binaries after there is a
| replacement for Linux's time-zone-like offset API.
|
| * The obsolete functions ftime has been deprecated and will be removed from
| a future version of glibc. Application should use clock_gettime instead.
|
| * The sparc*-*linux-gnu configurations targeting v7 or order architecture
| are no longer supported. For v8 only implementations with native CAS
| instruction are still supported (such as LEON).
PS5, Line 85:
OK.
|
| +* If a lazy binding failure happens during dlopen, during the execution of
| + an ELF constructor, the process is now terminated. Previously, the
| + dynamic loader would return NULL from dlopen, with the lazy binding error
| + captured in a dlerror message. In general, this is unsafe because
| + resetting the stack in an arbitrary function call is not possible.
| +
| Changes to build and runtime requirements:
|
--
Gerrit-Project: glibc
Gerrit-Branch: master
Gerrit-Change-Id: I6b1addfe2e30f50a1781595f046f44173db9491a
Gerrit-Change-Number: 467
Gerrit-PatchSet: 5
Gerrit-Owner: Florian Weimer <fweimer@redhat.com>
Gerrit-Reviewer: Carlos O'Donell <carlos@redhat.com>
Gerrit-Reviewer: Florian Weimer <fweimer@redhat.com>
Gerrit-Comment-Date: Wed, 27 Nov 2019 19:04:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-11-27 19:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 19:20 [review] " Florian Weimer (Code Review)
2019-11-13 12:57 ` [review v2] " Florian Weimer (Code Review)
2019-11-15 16:02 ` [review v3] " Florian Weimer (Code Review)
2019-11-18 16:24 ` Carlos O'Donell (Code Review)
2019-11-18 17:01 ` Florian Weimer (Code Review)
2019-11-27 15:20 ` Florian Weimer (Code Review)
2019-11-27 15:56 ` [review v4] " Florian Weimer (Code Review)
2019-11-27 18:34 ` Carlos O'Donell (Code Review)
2019-11-27 19:01 ` [review v5] " Florian Weimer (Code Review)
2019-11-27 19:04 ` Carlos O'Donell (Code Review) [this message]
2019-11-27 20:31 ` [pushed] " Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191127190415.39EB220AF6@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=fweimer@redhat.com \
--cc=gnutoolchain-gerrit@osci.io \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).