public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Subject: [PATCH v2] linux: Add inline getcpu implementation for sched_getcpu and getcpu
Date: Tue, 03 Dec 2019 13:56:00 -0000	[thread overview]
Message-ID: <20191203135617.14709-1-adhemerval.zanella@linaro.org> (raw)
In-Reply-To: <22ce01a8-9f61-4588-bb50-1d3aa4a302e1@linaro.org>

Changes from previous version:

  - Add getcpu_priv.h with a common implementation for both sched_getcpu
    and getcpu.

Checked on x86_64-linux-gnu.
---
 sysdeps/unix/sysv/linux/getcpu.c       | 16 ++---------
 sysdeps/unix/sysv/linux/getcpu_priv.h  | 38 ++++++++++++++++++++++++++
 sysdeps/unix/sysv/linux/sched_getcpu.c | 17 ++----------
 3 files changed, 42 insertions(+), 29 deletions(-)
 create mode 100644 sysdeps/unix/sysv/linux/getcpu_priv.h

diff --git a/sysdeps/unix/sysv/linux/getcpu.c b/sysdeps/unix/sysv/linux/getcpu.c
index fdd27203af..0ce49bb027 100644
--- a/sysdeps/unix/sysv/linux/getcpu.c
+++ b/sysdeps/unix/sysv/linux/getcpu.c
@@ -15,24 +15,12 @@
    License along with the GNU C Library; if not, see
    <https://www.gnu.org/licenses/>.  */
 
-#include <errno.h>
-#include <sched.h>
-#include <sysdep.h>
-
-#ifdef HAVE_GETCPU_VSYSCALL
-# define HAVE_VSYSCALL
-#endif
-#include <sysdep-vdso.h>
+#include <getcpu_priv.h>
 
 int
 __getcpu (unsigned int *cpu, unsigned int *node)
 {
-#ifdef __NR_getcpu
-  return INLINE_VSYSCALL (getcpu, 3, cpu, node, NULL);
-#else
-  __set_errno (ENOSYS);
-  return -1;
-#endif
+  return getcpu_priv (cpu, node);
 }
 weak_alias (__getcpu, getcpu)
 libc_hidden_def (__getcpu)
diff --git a/sysdeps/unix/sysv/linux/getcpu_priv.h b/sysdeps/unix/sysv/linux/getcpu_priv.h
new file mode 100644
index 0000000000..a347dde56e
--- /dev/null
+++ b/sysdeps/unix/sysv/linux/getcpu_priv.h
@@ -0,0 +1,38 @@
+/* Determine CPU and NUMA node on which the calling thread is running.
+   Linux private implementation.
+   Copyright (C) 2019 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <https://www.gnu.org/licenses/>.  */
+
+#ifndef _GETCPU_PRIV_H
+#define _GETCPY_PRIV_H
+
+#include <sched.h>
+#include <errno.h>
+#include <sysdep.h>
+
+#ifdef HAVE_GETCPU_VSYSCALL
+# define HAVE_VSYSCALL
+#endif
+#include <sysdep-vdso.h>
+
+static inline int
+getcpu_priv (unsigned int *cpu, unsigned int *node)
+{
+  return INLINE_VSYSCALL (getcpu, 3, cpu, node, NULL);
+}
+
+#endif
diff --git a/sysdeps/unix/sysv/linux/sched_getcpu.c b/sysdeps/unix/sysv/linux/sched_getcpu.c
index 65dd9fdda7..463e5e86bc 100644
--- a/sysdeps/unix/sysv/linux/sched_getcpu.c
+++ b/sysdeps/unix/sysv/linux/sched_getcpu.c
@@ -15,25 +15,12 @@
    License along with the GNU C Library; if not, see
    <https://www.gnu.org/licenses/>.  */
 
-#include <errno.h>
-#include <sched.h>
-#include <sysdep.h>
-
-#ifdef HAVE_GETCPU_VSYSCALL
-# define HAVE_VSYSCALL
-#endif
-#include <sysdep-vdso.h>
+#include <getcpu_priv.h>
 
 int
 sched_getcpu (void)
 {
-#ifdef __NR_getcpu
   unsigned int cpu;
-  int r = INLINE_VSYSCALL (getcpu, 3, &cpu, NULL, NULL);
-
+  int r = getcpu_priv (&cpu, NULL);
   return r == -1 ? r : cpu;
-#else
-  __set_errno (ENOSYS);
-  return -1;
-#endif
 }
-- 
2.17.1

      reply	other threads:[~2019-12-03 13:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-29 21:03 [PATCH 1/7] linux: Update x86 vDSO symbols Adhemerval Zanella
2019-11-29 21:03 ` [PATCH 7/7] elf: Move vDSO setup to rtld Adhemerval Zanella
2019-11-29 21:03 ` [PATCH 2/7] x86: Make x32 use x86 time implementation Adhemerval Zanella
2019-11-29 21:03 ` [PATCH 5/7] elf: Enable relro for static build Adhemerval Zanella
2019-12-01  9:55   ` Florian Weimer
2019-12-02 13:57     ` Adhemerval Zanella
2019-12-02 18:25       ` Florian Weimer
2019-12-02 18:54         ` Adhemerval Zanella
2019-12-02 19:03           ` Florian Weimer
2019-12-02 19:33             ` Adhemerval Zanella
2019-12-03 13:53               ` [PATCH v2] " Adhemerval Zanella
2019-11-29 21:03 ` [PATCH 4/7] linux: Update mips vDSO symbols Adhemerval Zanella
2019-11-29 21:03 ` [PATCH 3/7] Remove vDSO support from make-syscall.sh Adhemerval Zanella
2019-11-29 21:03 ` [PATCH 6/7] linux: Refactor sched_getcpu in terms of getcpu Adhemerval Zanella
2019-12-01 14:22   ` Florian Weimer
2019-12-02 14:00     ` Adhemerval Zanella
2019-12-03 13:56       ` Adhemerval Zanella [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191203135617.14709-1-adhemerval.zanella@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).