From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113703 invoked by alias); 9 Dec 2019 18:16:40 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 113693 invoked by uid 89); 9 Dec 2019 18:16:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=showed, Credit, H*MI:sk:be0147f, H*i:sk:733c949 X-HELO: smtpout1.mo528.mail-out.ovh.net Date: Mon, 09 Dec 2019 18:16:00 -0000 From: "Gabriel F. T. Gomes" To: Paul E Murphy CC: Zack Weinberg , GNU C Library Subject: Re: [PATCH v3 01/11] ldbl-128ibm-compat: Fix selection of GNU and ISO C99 scanf Message-ID: <20191209151622.54e7b893@tereshkova> In-Reply-To: <733c9494-34fe-b169-5a94-aa7dc0a0016e@linux.ibm.com> References: <20191203170540.18428-1-gabriel@inconstante.net.br> <20191203170540.18428-2-gabriel@inconstante.net.br> <733c9494-34fe-b169-5a94-aa7dc0a0016e@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Ovh-Tracer-Id: 10341109173279116856 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrudeltddgudduvdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeffhffvuffkjghfofggtgfgihesthejredtredtvdenucfhrhhomhepfdfirggsrhhivghlucfhrdcuvfdrucfiohhmvghsfdcuoehgrggsrhhivghlsehinhgtohhnshhtrghnthgvrdhnvghtrdgsrheqnecukfhppedtrddtrddtrddtpdduledurddvhedtrddufeeirdduvdeknecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopefgigegrdgvmhhprdhlohgtrghlpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpehgrggsrhhivghlsehinhgtohhnshhtrghnthgvrdgvthhirdgsrhdprhgtphhtthhopehlihgstgdqrghlphhhrgesshhouhhrtggvfigrrhgvrdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-SW-Source: 2019-12/txt/msg00303.txt.bz2 On Mon, 09 Dec 2019, Paul E Murphy wrote: > >On 12/9/19 10:49 AM, Zack Weinberg wrote: >> >> Credit is actually due to Gabriel; if I understand correctly, I >> _introduced_ a bug here! Zack's patch did the right thing... However, I started working on powerpc's IEEE long double implementation before his patch landed on master and I didn't notice the change in default behaviour. The potential bug never really showed up, because ldbl-128ibm-compat is not yet in the Implies file, so the __*ieee128 functions were never really exposed. >I stand corrected. I wonder how frail some of these tests might become >as they age. Is framework available today to verify tests are linking >against the desired variants of a symbol? The tests in the subsequent patch (2/11) try to make that better, by trying to read a long double value with %as when in ISO C99 mode. Now I'm wondering that it should try to read a string (and allocate it automatically) in the -D_GNU_SOURCE -std=c89 case, i.e.: also use %as, but expect a different output. Since each case should produce different outputs (even if the input is the same), I think that will help verify that the correct symbol gets selected.