From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45131 invoked by alias); 12 Dec 2019 13:42:47 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 45120 invoked by uid 89); 12 Dec 2019 13:42:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=HX-Envelope-From:sk:gabriel, H*M:lan, H*f:sk:CAKCAbM, H*MI:sk:CAKCAbM X-HELO: smtpout1.mo528.mail-out.ovh.net Date: Thu, 12 Dec 2019 13:42:00 -0000 From: "Gabriel F. T. Gomes" To: Paul E Murphy CC: Zack Weinberg , GNU C Library Subject: Re: [PATCH v3 01/11] ldbl-128ibm-compat: Fix selection of GNU and ISO C99 scanf Message-ID: <20191212104226.354b2f5a@tereshkova.lan> In-Reply-To: References: <20191203170540.18428-1-gabriel@inconstante.net.br> <20191203170540.18428-2-gabriel@inconstante.net.br> <733c9494-34fe-b169-5a94-aa7dc0a0016e@linux.ibm.com> <20191209151622.54e7b893@tereshkova> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Ovh-Tracer-Id: 4886968547413708344 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrudeljedgheeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvffukfgjfhfogggtgfhisehtjeertdertddvnecuhfhrohhmpedfifgrsghrihgvlhcuhfdrucfvrdcuifhomhgvshdfuceoghgrsghrihgvlhesihhntghonhhsthgrnhhtvgdrnhgvthdrsghrqeenucffohhmrghinhepshhouhhrtggvfigrrhgvrdhorhhgnecukfhppedtrddtrddtrddtpdefvddruddtgedrudekrddvtdefnecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopefgigegrdgvmhhprdhlohgtrghlpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpehgrggsrhhivghlsehinhgtohhnshhtrghnthgvrdgvthhirdgsrhdprhgtphhtthhopehlihgstgdqrghlphhhrgesshhouhhrtggvfigrrhgvrdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-SW-Source: 2019-12/txt/msg00417.txt.bz2 On Mon, 09 Dec 2019, Paul E Murphy wrote: >There are two tests wrapped in each: One to verify the headers select >the appropriate variant, secondly verifying the long double >implementation is correct. The former is sometimes more complicated >than ibm128 or ieee128. Right. >I am not suggesting this work be included in this patchset, but would it >be approaching something like `assert (&(scanf) == &FPTR_EXPECTED >(scanf))` to this and similar printf tests (e.g fortified printf)? Such >could quickly tell us if we need to update our tests. Sounds good, maybe we could write something similar to elf/tst-addr1.c [1], with hardcoded function names. [1] https://sourceware.org/git/?p=glibc.git;a=blob;f=elf/tst-addr1.c;h=68ff74aabd4dbe5b4dc1c98ebd2df2f66e080890;hb=HEAD