From: "Gabriel F. T. Gomes" <gabriel@inconstante.net.br>
To: Paul E Murphy <murphyp@linux.ibm.com>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH v3 02/11] ldbl-128ibm-compat: Add ISO C99 versions of scanf functions
Date: Fri, 13 Dec 2019 21:13:00 -0000 [thread overview]
Message-ID: <20191213181322.53f9cf17@tereshkova> (raw)
In-Reply-To: <924787d8-daa3-aca6-c042-908f5b1c4a22@linux.ibm.com>
On Mon, 09 Dec 2019, Paul E Murphy wrote:
>On 12/3/19 11:05 AM, Gabriel F. T. Gomes wrote:
>> From: "Gabriel F. T. Gomes" <gabrielftg@linux.ibm.com>
>>
>> + /* For ISO C99, scan the single-precision value with "%as" to test
>> + that __isoc99_*scanf ignores the 's'. For DEPRECATED_SCANF, do not
>> + use "%as", because that would try to scan a string and allocate
>> + space for it. */
>> +#if __GLIBC_USE (DEPRECATED_SCANF)
>> +# define FMT "%La %a"
>> +#else
>> +# define FMT "%La %as"
>> +#endif
>
>That does simplify the patch nicely. LGTM.
Thanks, this and the preceding patch are now committed.
next prev parent reply other threads:[~2019-12-13 21:13 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 17:05 [PATCH v3 00/11] Add IEEE long double <-> string functions for powerpc64le Gabriel F. T. Gomes
2019-12-03 17:05 ` [PATCH v3 01/11] ldbl-128ibm-compat: Fix selection of GNU and ISO C99 scanf Gabriel F. T. Gomes
2019-12-09 16:46 ` Paul E Murphy
2019-12-09 16:50 ` Zack Weinberg
2019-12-09 17:09 ` Paul E Murphy
2019-12-09 18:16 ` Gabriel F. T. Gomes
2019-12-09 20:31 ` Paul E Murphy
2019-12-12 13:42 ` Gabriel F. T. Gomes
2019-12-03 17:06 ` [PATCH v3 03/11] Refactor *cvt functions implementation (1-4/5) Gabriel F. T. Gomes
2019-12-09 21:25 ` Paul E Murphy
2019-12-13 20:19 ` Gabriel F. T. Gomes
2019-12-03 17:06 ` [PATCH v3 06/11] Do not redirect calls to __GI_* symbols, when redirecting to *ieee128 Gabriel F. T. Gomes
2019-12-03 17:06 ` [PATCH v3 08/11] Avoid compat symbols for totalorder in powerpc64le IEEE long double Gabriel F. T. Gomes
2019-12-03 17:06 ` [PATCH v3 02/11] ldbl-128ibm-compat: Add ISO C99 versions of scanf functions Gabriel F. T. Gomes
2019-12-09 18:09 ` Paul E Murphy
2019-12-13 21:13 ` Gabriel F. T. Gomes [this message]
2019-12-03 17:06 ` [PATCH v3 07/11] ldbl-128ibm-compat: Compiler flags for stdio functions Gabriel F. T. Gomes
2019-12-03 17:06 ` [PATCH v3 10/11] powerpc64le: Require a compiler with -mno-gnu-attribute Gabriel F. T. Gomes
2019-12-03 17:06 ` [PATCH v3 05/11] ldbl-128ibm-compat: Add *cvt functions Gabriel F. T. Gomes
2019-12-09 23:13 ` Paul E Murphy
2019-12-13 20:03 ` Gabriel F. T. Gomes
2019-12-03 17:06 ` [PATCH v3 04/11] Refactor *cvt functions implementation (5/5) Gabriel F. T. Gomes
2019-12-03 17:06 ` [PATCH v3 09/11] ldbl-128ibm-compat: Do not mix -mabi=*longdouble and -mlong-double-128 Gabriel F. T. Gomes
2019-12-03 17:07 ` [PATCH v3 11/11] RFC: powerpc64le: Enable support for IEEE long double Gabriel F. T. Gomes
2019-12-09 23:47 ` Paul E Murphy
2019-12-13 22:41 ` Gabriel F. T. Gomes
2019-12-13 23:46 ` Paul E Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191213181322.53f9cf17@tereshkova \
--to=gabriel@inconstante.net.br \
--cc=libc-alpha@sourceware.org \
--cc=murphyp@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).