public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] getpt.3: Remove mention of O_NOCTTY
@ 2019-12-31 17:01 Samuel Thibault
  2020-01-01  7:27 ` Michael Kerrisk (man-pages)
  0 siblings, 1 reply; 2+ messages in thread
From: Samuel Thibault @ 2019-12-31 17:01 UTC (permalink / raw)
  To: mtk.manpages; +Cc: linux-man, libc-alpha

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

The glibc implementation of getpt has actually never been setting
O_NOCTTY when opening /dev/ptmx or BSD ptys.

Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 234 bytes --]

--- ./man3/getpt.3.orig	2019-12-31 17:58:50.046714199 +0100
+++ ./man3/getpt.3	2019-12-31 17:59:00.706722831 +0100
@@ -21,7 +21,7 @@
 .PP
 .in +4n
 .EX
-open("/dev/ptmx", O_RDWR | O_NOCTTY);
+open("/dev/ptmx", O_RDWR);
 .EE
 .in
 .PP

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] getpt.3: Remove mention of O_NOCTTY
  2019-12-31 17:01 [PATCH] getpt.3: Remove mention of O_NOCTTY Samuel Thibault
@ 2020-01-01  7:27 ` Michael Kerrisk (man-pages)
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Kerrisk (man-pages) @ 2020-01-01  7:27 UTC (permalink / raw)
  To: Samuel Thibault, linux-man, libc-alpha; +Cc: mtk.manpages

Hello Samuel

On 12/31/19 6:01 PM, Samuel Thibault wrote:
> The glibc implementation of getpt has actually never been setting
> O_NOCTTY when opening /dev/ptmx or BSD ptys.
> 
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

(Inline patches preferred.)

Thanks. Patch applied.

Cheers,

Michael




-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-01-01  7:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-31 17:01 [PATCH] getpt.3: Remove mention of O_NOCTTY Samuel Thibault
2020-01-01  7:27 ` Michael Kerrisk (man-pages)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).