From: "Lucas A. M. Magalhaes" <lamm@linux.ibm.com>
To: libc-alpha@sourceware.org
Subject: [PATCH v4] Fix time/tst-cpuclock1 intermitent failures
Date: Tue, 10 Mar 2020 13:20:01 -0300 [thread overview]
Message-ID: <20200310162001.11737-1-lamm@linux.ibm.com> (raw)
In-Reply-To: <20200220181747.12898-1-lamm@linux.ibm.com>
This test fails intermittently in systems with heavy load as
CLOCK_PROCESS_CPUTIME_ID is subject to scheduler pressure. Thus the
test boundaries where relaxed to keep it from fail on this systems.
A refactor of the spent time checking was made with some support
functions. With the advantage to represent time jitter in percent
of the target.
The values used by the test boundaries are all empirical.
---
Hi,
changes on V4:
- move functions to support/timespec.c
- simplify functions
changes on V3:
- refactor support functions
- use existing timespec-sub function
changes on V2:
- Add support functions
---
support/timespec.c | 34 ++++++++++++++++++++++++++++++++
support/timespec.h | 6 ++++++
time/tst-cpuclock1.c | 46 +++++++++++++++-----------------------------
3 files changed, 55 insertions(+), 31 deletions(-)
diff --git a/support/timespec.c b/support/timespec.c
index ea6b947546..babe7801a2 100644
--- a/support/timespec.c
+++ b/support/timespec.c
@@ -19,6 +19,7 @@
#include <support/timespec.h>
#include <stdio.h>
#include <stdint.h>
+#include <assert.h>
void
test_timespec_before_impl (const char *file, int line,
@@ -57,3 +58,36 @@ test_timespec_equal_or_after_impl (const char *file, int line,
(intmax_t) diff.tv_sec, (intmax_t) diff.tv_nsec);
}
}
+
+/* Returns t normalized timespec with .tv_nsec < TIMESPEC_HZ
+ and the overflows added to .tv_sec. */
+struct timespec
+support_timespec_normalize (struct timespec t)
+{
+ t.tv_sec += t.tv_nsec / TIMESPEC_HZ;
+ t.tv_nsec -= t.tv_nsec % TIMESPEC_HZ;
+ return t;
+}
+
+/* Returns TRUE if deviation to base ratio is within the specified bounds, and
+FALSE otherwise.
+For example the call
+
+support_timespec_check_in_range(base, deviation, .5, 1.2);
+
+will check if
+
+.5 <= deviation/base <= 1.2
+
+In other words it will check if deviation time is within 50% to 120% of
+the base time. */
+int
+support_timespec_check_in_range (struct timespec base, struct timespec deviation,
+ double lower_bound, double upper_bound)
+{
+ assert (upper_bound >= lower_bound);
+ long base_norm = base.tv_sec * TIMESPEC_HZ + base.tv_nsec;
+ long deviation_norm = deviation.tv_sec * TIMESPEC_HZ + deviation.tv_nsec;
+ double ratio = (double)deviation_norm / base_norm;
+ return (lower_bound <= ratio && ratio <= upper_bound);
+}
diff --git a/support/timespec.h b/support/timespec.h
index c5852dfe75..98d18663d0 100644
--- a/support/timespec.h
+++ b/support/timespec.h
@@ -48,6 +48,12 @@ void test_timespec_equal_or_after_impl (const char *file, int line,
const struct timespec left,
const struct timespec right);
+struct timespec support_timespec_normalize (struct timespec t);
+
+int support_timespec_check_in_range (struct timespec base, struct timespec deviation,
+ double upper_bound, double lower_bound);
+
+
/* Check that the timespec on the left represents a time before the
time on the right. */
#define TEST_TIMESPEC_BEFORE(left, right) \
diff --git a/time/tst-cpuclock1.c b/time/tst-cpuclock1.c
index 0120906f23..0c67a61e0d 100644
--- a/time/tst-cpuclock1.c
+++ b/time/tst-cpuclock1.c
@@ -26,6 +26,7 @@
#include <signal.h>
#include <stdint.h>
#include <sys/wait.h>
+#include <support/timespec.h>
/* This function is intended to rack up both user and system time. */
static void
@@ -155,19 +156,13 @@ do_test (void)
printf ("live PID %d after sleep => %ju.%.9ju\n",
child, (uintmax_t) after.tv_sec, (uintmax_t) after.tv_nsec);
- struct timespec diff = { .tv_sec = after.tv_sec - before.tv_sec,
- .tv_nsec = after.tv_nsec - before.tv_nsec };
- if (diff.tv_nsec < 0)
- {
- --diff.tv_sec;
- diff.tv_nsec += 1000000000;
- }
- if (diff.tv_sec != 0
- || diff.tv_nsec > 600000000
- || diff.tv_nsec < 100000000)
+ support_timespec_normalize(after);
+ support_timespec_normalize(before);
+ struct timespec diff = timespec_sub(after, before);
+ if (!support_timespec_check_in_range(sleeptime, diff, .0025, 1.3))
{
printf ("before - after %ju.%.9ju outside reasonable range\n",
- (uintmax_t) diff.tv_sec, (uintmax_t) diff.tv_nsec);
+ (uintmax_t) diff.tv_sec, (uintmax_t) diff.tv_nsec);
result = 1;
}
@@ -194,19 +189,12 @@ do_test (void)
}
else
{
- struct timespec d = { .tv_sec = afterns.tv_sec - after.tv_sec,
- .tv_nsec = afterns.tv_nsec - after.tv_nsec };
- if (d.tv_nsec < 0)
- {
- --d.tv_sec;
- d.tv_nsec += 1000000000;
- }
- if (d.tv_sec > 0
- || d.tv_nsec < sleeptime.tv_nsec
- || d.tv_nsec > sleeptime.tv_nsec * 2)
+ support_timespec_normalize(afterns);
+ diff = timespec_sub(afterns, after);
+ if (!support_timespec_check_in_range(sleeptime, diff, .71, 1.6))
{
printf ("nanosleep time %ju.%.9ju outside reasonable range\n",
- (uintmax_t) d.tv_sec, (uintmax_t) d.tv_nsec);
+ (uintmax_t) diff.tv_sec, (uintmax_t) diff.tv_nsec);
result = 1;
}
}
@@ -241,17 +229,13 @@ do_test (void)
printf ("dead PID %d => %ju.%.9ju\n",
child, (uintmax_t) dead.tv_sec, (uintmax_t) dead.tv_nsec);
- diff.tv_sec = dead.tv_sec - after.tv_sec;
- diff.tv_nsec = dead.tv_nsec - after.tv_nsec;
- if (diff.tv_nsec < 0)
- {
- --diff.tv_sec;
- diff.tv_nsec += 1000000000;
- }
- if (diff.tv_sec != 0 || diff.tv_nsec > 200000000)
+ support_timespec_normalize(dead);
+ diff = timespec_sub(dead, after);
+ sleeptime.tv_nsec = 100000000;
+ if (!support_timespec_check_in_range(sleeptime, diff, .7, 1.6))
{
printf ("dead - after %ju.%.9ju outside reasonable range\n",
- (uintmax_t) diff.tv_sec, (uintmax_t) diff.tv_nsec);
+ (uintmax_t) diff.tv_sec, (uintmax_t) diff.tv_nsec);
result = 1;
}
--
2.20.1
next prev parent reply other threads:[~2020-03-10 16:20 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 14:48 [PATCH v2] " Lucas A. M. Magalhaes
2020-02-17 16:44 ` Lucas A. M. Magalhaes
2020-02-18 12:44 ` Adhemerval Zanella
2020-02-19 16:42 ` Lucas A. M. Magalhaes
2020-02-19 18:51 ` Adhemerval Zanella
2020-02-20 18:17 ` [PATCH v3] " Lucas A. M. Magalhaes
2020-03-04 19:24 ` Matheus Castanho
2020-03-06 17:31 ` Lucas A. M. Magalhaes
2020-03-10 16:20 ` Lucas A. M. Magalhaes [this message]
2020-03-10 16:30 ` [PATCH v4] " Andreas Schwab
2020-03-10 17:45 ` Carlos O'Donell
2020-03-23 17:20 ` [PATCH v5] " Lucas A. M. Magalhaes
2020-03-23 21:06 ` Carlos O'Donell
2020-03-24 19:42 ` Lucas A. M. Magalhaes
2020-03-31 18:55 ` Carlos O'Donell
2020-03-31 11:34 ` [PATCH v6] " Lucas A. M. Magalhaes
2020-03-31 19:02 ` Carlos O'Donell
2020-04-03 19:24 ` [PATCH v7] " Lucas A. M. Magalhaes
2020-04-03 20:48 ` Carlos O'Donell
2020-04-07 13:59 ` [PATCH v8] " Lucas A. M. Magalhaes
2020-04-16 17:30 ` Lucas A. M. Magalhaes
2020-04-16 19:21 ` Carlos O'Donell
2020-04-21 17:44 ` [PATCH v9] " Lucas A. M. Magalhaes
2020-05-11 17:41 ` Lucas A. M. Magalhaes
2020-05-25 11:46 ` Lucas A. M. Magalhaes
2020-06-08 13:58 ` Lucas A. M. Magalhaes
2020-06-08 16:52 ` Carlos O'Donell
2020-06-12 15:28 ` [PATCH v10] " Lucas A. M. Magalhaes
2020-06-25 17:26 ` Lucas A. M. Magalhaes
2020-07-06 14:15 ` Lucas A. M. Magalhaes
2020-07-07 20:12 ` Carlos O'Donell
2020-07-10 23:07 ` Tulio Magno Quites Machado Filho
2020-07-11 14:45 ` H.J. Lu
2020-07-11 16:31 ` H.J. Lu
2020-07-13 23:30 ` [PATCH] Correct timespec implementation [BZ #26232] H.J. Lu
2020-07-14 2:35 ` Carlos O'Donell
2020-07-14 11:16 ` Florian Weimer
2020-07-14 11:42 ` H.J. Lu
2020-07-14 12:04 ` H.J. Lu
2020-07-14 12:18 ` Florian Weimer
2020-07-14 13:12 ` H.J. Lu
2020-07-14 13:14 ` Florian Weimer
2020-07-14 13:17 ` H.J. Lu
2020-07-15 19:38 ` Paul Eggert
2020-07-15 19:44 ` H.J. Lu
2020-07-14 13:08 ` Lucas A. M. Magalhaes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200310162001.11737-1-lamm@linux.ibm.com \
--to=lamm@linux.ibm.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).