From: "Paul E. Murphy" <murphyp@linux.vnet.ibm.com>
To: libc-alpha@sourceware.org
Subject: [PATCH] float128: use builtin_signbitf128 always
Date: Tue, 7 Apr 2020 16:27:02 -0500 [thread overview]
Message-ID: <20200407212702.24301-1-murphyp@linux.vnet.ibm.com> (raw)
In-Reply-To: <20200407201516.11978-1-murphyp@linux.vnet.ibm.com>
The previous patch failed to account for the now unneeded
hidden_proto which mangles the symbol name in the shared
libary variants.
Also, fixup my email to use IBM IMAP email.
Tested on x86-64.
---8<---
The minimum GCC version has been raised to 6.2 for building
glibc. Therefore, follow the advice inside the implementation
and remove the GCC < 6 codepath.
Likewise, remove the hidden_proto as all internal usages should
inline now.
---
include/math.h | 1 -
sysdeps/ieee754/float128/s_signbitf128.c | 19 +------------------
2 files changed, 1 insertion(+), 19 deletions(-)
diff --git a/include/math.h b/include/math.h
index 3979c47400..e1c2a4eb64 100644
--- a/include/math.h
+++ b/include/math.h
@@ -29,7 +29,6 @@ hidden_proto (__isnanl)
hidden_proto (__finitef128)
hidden_proto (__isinff128)
hidden_proto (__isnanf128)
-hidden_proto (__signbitf128)
# endif
# endif
diff --git a/sysdeps/ieee754/float128/s_signbitf128.c b/sysdeps/ieee754/float128/s_signbitf128.c
index 1fc00658f8..c2a1097db6 100644
--- a/sysdeps/ieee754/float128/s_signbitf128.c
+++ b/sysdeps/ieee754/float128/s_signbitf128.c
@@ -17,21 +17,4 @@
<https://www.gnu.org/licenses/>. */
#include <float128_private.h>
-#include <math.h>
-#include <math_private.h>
-
-/* Once GCC >= 6.0 is required for building glibc, this implementation can
- be removed and replaced with an inclusion of ldbl-128/s_signbitl.c. */
-int
-__signbitf128 (_Float128 x)
-{
-#if __GNUC_PREREQ (6, 0)
- return __builtin_signbit (x);
-#else
- int64_t e;
-
- GET_FLOAT128_MSW64 (e, x);
- return e < 0;
-#endif
-}
-hidden_def (__signbitf128)
+#include "../ldbl-128/s_signbitl.c"
--
2.21.1
next prev parent reply other threads:[~2020-04-07 21:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 20:15 Paul E. Murphy
2020-04-07 21:27 ` Paul E. Murphy [this message]
2020-04-22 15:06 ` Florian Weimer
2020-05-04 21:17 ` Paul E Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200407212702.24301-1-murphyp@linux.vnet.ibm.com \
--to=murphyp@linux.vnet.ibm.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).