From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by sourceware.org (Postfix) with ESMTPS id 3B81A385BF81 for ; Wed, 8 Apr 2020 07:11:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3B81A385BF81 Received: by mail-pg1-x52e.google.com with SMTP id s4so2913243pgk.10 for ; Wed, 08 Apr 2020 00:11:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=SsRmJzfdvx4v5D0sddQUnXUy5GJDORpYKoBUY+A/Vss=; b=WC1mb/vkhCOqcHViCEyYTZReX/R0oU3twz9HTY2eKSFDr0l+lIp1Kq0SY+FNndAaa5 HfFtsoiJePNHy0WOkRKmnsVlKSmhQYU/AU2kxHxe8R+T1gXrbuad9g0dat7SUpah2Y6l lfChPUzTlNTVsKQwRguP/1yTStQ0058tT3q47ed3UKX6/WvzY7ytK8bfA+mC/f9RJeCE JtP320QP7bsjytH9XZAVHCxsWOko9ZUXxvDoKxARPimrGTtyr2X2d7CfxlHd8Ah1VVBq gy77Opo6alNhs/V+mYfoLpzv2mLawKBq2drkgGOFGgoDxMG1W6ZuqBwfUs8Jb5WnuwON WHew== X-Gm-Message-State: AGi0PuaLQYCiESU0ou23rDXLjVYzrSdnFsIPgJ2h0J2VUhM78T0sYyvU 86aGUCSEn2LQv9aG3/4oVV0hMa9EOUg= X-Google-Smtp-Source: APiQypJMNt3oDHj+meAeEhiCCVCUAyqQ0QscdBdsPVzUCuMno85gC4reLIyTwK8qLbcWa6u4E7jBQw== X-Received: by 2002:a63:4d57:: with SMTP id n23mr5963173pgl.59.1586329874188; Wed, 08 Apr 2020 00:11:14 -0700 (PDT) Received: from google.com ([2620:15c:2ce:0:9efe:9f1:9267:2b27]) by smtp.gmail.com with ESMTPSA id m14sm3461941pje.19.2020.04.08.00.11.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Apr 2020 00:11:13 -0700 (PDT) Date: Wed, 8 Apr 2020 00:11:10 -0700 From: Fangrui Song To: Florian Weimer Cc: Fangrui Song via Libc-alpha Subject: Re: [PATCH] configure: Allow LD to be a linker other than GNU ld and gold Message-ID: <20200408071110.7pncjba3y2vfgntt@google.com> References: <20200313204634.7jrgd2m5ga3l5drk@google.com> <87369e32aq.fsf@oldenburg2.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <87369e32aq.fsf@oldenburg2.str.redhat.com> X-Spam-Status: No, score=-26.2 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, FSL_HELO_FAKE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Apr 2020 07:11:16 -0000 On 2020-04-08, Florian Weimer wrote: >* Fangrui Song via Libc-alpha: > >> When using lld as the linker, configure prints a confusing message. >> >> *** These critical programs are missing or too old: GNU ld >> >> lld>=8 can build glibc with very few patches. lld may be built with a >> custom version information (e.g. git commit ID), so a version check is not >> useful at all. > >If additional patches are still required, we should not change the >configure check at this time. > >To be clear, this is an objection from me. Sorry. > >Thanks, >Florian Hi Florian, Can you help with https://sourceware.org/pipermail/libc-alpha/2020-March/111910.html ? To be honest, this LD capability check looks very strange to me. I believe a good configure time check should check the problem explicitly, rather than the version, e.g. if a known version can silently cause a bug, then we should reject it. The current version check can just give false positives and/or false negatives. https://ewontfix.com/13/ I am doing my best to make the least intrusive change to configure.