From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) by sourceware.org (Postfix) with ESMTPS id 2B740385DC0D for ; Tue, 14 Apr 2020 12:14:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2B740385DC0D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=lukma@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 491ktg54G3z1rs00; Tue, 14 Apr 2020 14:14:19 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 491ktg3009z1qtwT; Tue, 14 Apr 2020 14:14:19 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id zUVklc2VXsL8; Tue, 14 Apr 2020 14:14:18 +0200 (CEST) X-Auth-Info: L6YT0ln1pc/zwtBmU1B5CYXntztctdyUovqSHZhz4zI= Received: from jawa (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Tue, 14 Apr 2020 14:14:18 +0200 (CEST) Date: Tue, 14 Apr 2020 14:14:17 +0200 From: Lukasz Majewski To: Florian Weimer Cc: Joseph Myers , Adhemerval Zanella , GNU C Library , Andreas Schwab , Alistair Francis Subject: Re: [PATCH v2 5/5] y2038: Replace __clock_gettime with __clock_gettime64 Message-ID: <20200414141417.35e10361@jawa> In-Reply-To: <20200406230304.0717e85f@jawa> References: <20200326080641.10193-1-lukma@denx.de> <20200326080641.10193-6-lukma@denx.de> <87369gd2dj.fsf@mid.deneb.enyo.de> <20200406230304.0717e85f@jawa> Organization: denx.de X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/mRe6eI9/KGEZJbpFDYUCsxi"; protocol="application/pgp-signature" X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KAM_NUMSUBJECT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2020 12:14:22 -0000 --Sig_/mRe6eI9/KGEZJbpFDYUCsxi Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Dear Community,=20 > Hi Florian, >=20 > > * Lukasz Majewski: > > =20 > > > The __clock_gettime internal function is not supporting 64 bit > > > time on architectures with __WORDSIZE =3D=3D 32 and __TIMESIZE !=3D 64 > > > (like e.g. ARM 32 bit). > > > > > > The __clock_gettime64 shall be used instead in the glibc itself as > > > it =20 > >=20 > > The __clock_gettime64 function? =20 >=20 > Yes. Correct. Thanks for spotting it. >=20 > > =20 > > > supports 64 bit time on those systems. > > > This change does not bring any change to systems with __WORDSIZE > > > =3D=3D 64 as for them the __clock_gettime64 is aliased to > > > __clock_gettime (in ./include/time.h). =20 > >=20 > > Should this patch remove the __clock_gettime GLIBC_PRIVATE export? =20 >=20 > No. This work is just a first step. The nptl and pthread code still > use __clock_gettime internally. I will prepare __clock_gettime > conversion to __clock_gettime64 for those parts of glibc in latter > patches. Are there any more comments regarding this patch set? In other word - is it eligible for pulling? >=20 >=20 > Best regards, >=20 > Lukasz Majewski >=20 > -- >=20 > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: > lukma@denx.de Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/mRe6eI9/KGEZJbpFDYUCsxi Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAl6VqRkACgkQAR8vZIA0 zr1kOAgAgM2BU4dPGEtI9nho4iNn6ebhfdAVS6fah57Pbsot5LVzmRXPv3u8RB6r Z+KDh/6DdD97VslMCdlC9qaC1oFrWqOPdjg26oDryd4iKR9XMfSjaZOgcYtYa9PJ 7UTCxyAxbXM0zEe/ALlmk4b6WT2Hpa1VJsqZuOYSE0VW693pztYugQFP4rmR8o7G BO3Q0LvPf9OnNvF9ZhKktSMzlPB1p65z+QJLYTv5heGOiDywJ+XZnbPnqfHAjmm3 IkkGqpGg1jnerhGtRKLMNnHO6adxocPeDRNbsGVfzmy9M4lRqpsjqchgMhUd4I6q kFcFejqny6NkGIV3NRKmr1dsdMJcOQ== =unpn -----END PGP SIGNATURE----- --Sig_/mRe6eI9/KGEZJbpFDYUCsxi--