From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from brightrain.aerifal.cx (216-12-86-13.cv.mvl.ntelos.net [216.12.86.13]) by sourceware.org (Postfix) with ESMTPS id 1B1AA385C426 for ; Thu, 16 Apr 2020 15:37:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1B1AA385C426 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=libc.org Authentication-Results: sourceware.org; spf=none smtp.mailfrom=dalias@libc.org Date: Thu, 16 Apr 2020 11:37:56 -0400 From: Rich Felker To: Adhemerval Zanella Cc: Nicholas Piggin , libc-alpha@sourceware.org, musl@lists.openwall.com, linuxppc-dev@lists.ozlabs.org, libc-dev@lists.llvm.org Subject: Re: [musl] Powerpc Linux 'scv' system call ABI proposal take 2 Message-ID: <20200416153756.GU11469@brightrain.aerifal.cx> References: <1586931450.ub4c8cq8dj.astroid@bobo.none> <20200415225539.GL11469@brightrain.aerifal.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=0.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KAM_NUMSUBJECT, KHOP_HELO_FCRDNS, RDNS_DYNAMIC, SPF_HELO_NONE, SPF_NONE autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2020 15:37:58 -0000 On Thu, Apr 16, 2020 at 11:16:04AM -0300, Adhemerval Zanella wrote: > > My preference would be that it work just like the i386 AT_SYSINFO > > where you just replace "int $128" with "call *%%gs:16" and the kernel > > provides a stub in the vdso that performs either scv or the old > > mechanism with the same calling convention. Then if the kernel doesn't > > provide it (because the kernel is too old) libc would have to provide > > its own stub that uses the legacy method and matches the calling > > convention of the one the kernel is expected to provide. > > What about pthread cancellation and the requirement of checking the > cancellable syscall anchors in asynchronous cancellation? My plan is > still to use musl strategy on glibc (BZ#12683) and for i686 it > requires to always use old int$128 for program that uses cancellation > (static case) or just threads (dynamic mode, which should be more > common on glibc). > > Using the i686 strategy of a vDSO bridge symbol would require to always > fallback to 'sc' to still use the same cancellation strategy (and > thus defeating this optimization in such cases). Yes, I assumed it would be the same, ignoring the new syscall mechanism for cancellable syscalls. While there are some exceptions, cancellable syscalls are generally not hot paths but things that are expected to block and to have significant amounts of work to do in kernelspace, so saving a few tens of cycles is rather pointless. It's possible to do a branch/multiple versions of the syscall asm for cancellation but would require extending the cancellation handler to support checking against multiple independent address ranges or using some alternate markup of them. Rich