* [PATCH] malloc: fix memleak in function muntrace
@ 2020-04-19 7:37 chenzefeng
2020-04-19 11:39 ` Florian Weimer
0 siblings, 1 reply; 3+ messages in thread
From: chenzefeng @ 2020-04-19 7:37 UTC (permalink / raw)
To: libc-alpha; +Cc: liucheng32, chenzefeng2, zengweilin
when we call functons as follow:
mtrace();
...
muntrace();
It would cause memleak, for the mtrace malloc some memory:
mtd = malloc(TRACE_BUFFER_SIZE);
and it would not be free. Therefor it should be freed in muntrace.
Signed-off-by: chenzefeng <chenzefeng2@huawei.com>
---
malloc/mtrace.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/malloc/mtrace.c b/malloc/mtrace.c
index 7e7719df97..0b92106e6e 100644
--- a/malloc/mtrace.c
+++ b/malloc/mtrace.c
@@ -365,4 +365,6 @@ muntrace (void)
fprintf (f, "= End\n");
fclose (f);
+ if (mtb != NULL)
+ free (mtb);
}
--
2.12.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] malloc: fix memleak in function muntrace
2020-04-19 7:37 [PATCH] malloc: fix memleak in function muntrace chenzefeng
@ 2020-04-19 11:39 ` Florian Weimer
2020-04-20 13:49 ` chenzefeng (A)
0 siblings, 1 reply; 3+ messages in thread
From: Florian Weimer @ 2020-04-19 11:39 UTC (permalink / raw)
To: chenzefeng; +Cc: libc-alpha, liucheng32, zengweilin
* chenzefeng:
> diff --git a/malloc/mtrace.c b/malloc/mtrace.c
> index 7e7719df97..0b92106e6e 100644
> --- a/malloc/mtrace.c
> +++ b/malloc/mtrace.c
> @@ -365,4 +365,6 @@ muntrace (void)
>
> fprintf (f, "= End\n");
> fclose (f);
> + if (mtb != NULL)
> + free (mtb);
> }
I don't think this will build. The global variable is called
malloc_trace_buffer.
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] malloc: fix memleak in function muntrace
2020-04-19 11:39 ` Florian Weimer
@ 2020-04-20 13:49 ` chenzefeng (A)
0 siblings, 0 replies; 3+ messages in thread
From: chenzefeng (A) @ 2020-04-20 13:49 UTC (permalink / raw)
To: Florian Weimer; +Cc: libc-alpha, liucheng (G), Zengweilin
* Florian Weimer:
>* chenzefeng:
>> diff --git a/malloc/mtrace.c b/malloc/mtrace.c index
>> 7e7719df97..0b92106e6e 100644
>> --- a/malloc/mtrace.c
>> +++ b/malloc/mtrace.c
>> @@ -365,4 +365,6 @@ muntrace (void)
>>
>> fprintf (f, "= End\n");
>> fclose (f);
>> + if (mtb != NULL)
>> + free (mtb);
>> }
>I don't think this will build. The global variable is called malloc_trace_buffer.
I am sorry, I had not got the correctly patch from local file. I commit it again, thanks for you review.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-20 13:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-19 7:37 [PATCH] malloc: fix memleak in function muntrace chenzefeng
2020-04-19 11:39 ` Florian Weimer
2020-04-20 13:49 ` chenzefeng (A)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).