From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by sourceware.org (Postfix) with ESMTPS id F0D1A384B0C1 for ; Tue, 21 Apr 2020 13:48:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F0D1A384B0C1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=lukma@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4964fH3Jrpz1r56L; Tue, 21 Apr 2020 15:48:39 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4964fH1J2sz1qql0; Tue, 21 Apr 2020 15:48:39 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id dxvPrvUbi-W1; Tue, 21 Apr 2020 15:48:38 +0200 (CEST) X-Auth-Info: oSuNvKkYnDwg5YrLM/+rxLGIfyyPAuVMgap7giHpM2U= Received: from jawa (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Tue, 21 Apr 2020 15:48:37 +0200 (CEST) Date: Tue, 21 Apr 2020 15:48:31 +0200 From: Lukasz Majewski To: Florian Weimer Cc: Andreas Schwab , Alistair Francis , GNU C Library , Joseph Myers , Adhemerval Zanella Subject: Re: [PATCH v2 5/5] y2038: Replace __clock_gettime with __clock_gettime64 Message-ID: <20200421154831.3b788fa4@jawa> In-Reply-To: <20200414141417.35e10361@jawa> References: <20200326080641.10193-1-lukma@denx.de> <20200326080641.10193-6-lukma@denx.de> <87369gd2dj.fsf@mid.deneb.enyo.de> <20200406230304.0717e85f@jawa> <20200414141417.35e10361@jawa> Organization: denx.de X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/DKGAE/7=1UYvXbGhrul=_U="; protocol="application/pgp-signature" X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KAM_NUMSUBJECT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Apr 2020 13:48:42 -0000 --Sig_/DKGAE/7=1UYvXbGhrul=_U= Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Dear Community, > Dear Community,=20 >=20 >=20 > > Hi Florian, > > =20 > > > * Lukasz Majewski: > > > =20 > > > > The __clock_gettime internal function is not supporting 64 bit > > > > time on architectures with __WORDSIZE =3D=3D 32 and __TIMESIZE !=3D= 64 > > > > (like e.g. ARM 32 bit). > > > > > > > > The __clock_gettime64 shall be used instead in the glibc itself > > > > as it =20 > > >=20 > > > The __clock_gettime64 function? =20 > >=20 > > Yes. Correct. Thanks for spotting it. > > =20 > > > =20 > > > > supports 64 bit time on those systems. > > > > This change does not bring any change to systems with __WORDSIZE > > > > =3D=3D 64 as for them the __clock_gettime64 is aliased to > > > > __clock_gettime (in ./include/time.h). =20 > > >=20 > > > Should this patch remove the __clock_gettime GLIBC_PRIVATE > > > export? =20 > >=20 > > No. This work is just a first step. The nptl and pthread code still > > use __clock_gettime internally. I will prepare __clock_gettime > > conversion to __clock_gettime64 for those parts of glibc in latter > > patches. =20 >=20 > Are there any more comments regarding this patch set? In other word - > is it eligible for pulling? Are there any more comments? >=20 > >=20 > >=20 > > Best regards, > >=20 > > Lukasz Majewski > >=20 > > -- > >=20 > > DENX Software Engineering GmbH, Managing Director: Wolfgang > > Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, > > Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: > > lukma@denx.de =20 >=20 >=20 >=20 >=20 > Best regards, >=20 > Lukasz Majewski >=20 > -- >=20 > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: > lukma@denx.de Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/DKGAE/7=1UYvXbGhrul=_U= Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAl6e+a8ACgkQAR8vZIA0 zr1JOwf+Ndkihm9eMuYV6BHTq1i/mSpwEUnTYzqy8tYYlPWFtS7ZJY+UXqbE9Zi8 BIn6Fao0IpBOkrp+ovubEBI8hFz7QLjKExvVivt5dUfTfuhpK8BvP0YjbERZr0y3 E2j4RoCa6Xbqej/UmaT6pfOu6osZ0xYoFC4MtYKgZlQikUk+L4QjMhr3lD1dp5p/ o70gI/57DS/DzgX7DNSNWE8BJeua74l9LJ0fIQ6LljjhU3SInYI+LgH7Clmllmlf w6gKxKpb/1vvmPqO+Jwn5cxV6/jXDOA1fLRfa46EzavVq11aVWZ7pHq+8GB/wYcs WP46uYAkHBt+OAyfnyWI3RxcDDKp7g== =R+Yh -----END PGP SIGNATURE----- --Sig_/DKGAE/7=1UYvXbGhrul=_U=--