public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH v4] malloc: fix memleak in function muntrace
@ 2020-04-24  1:24 chenzefeng
  0 siblings, 0 replies; only message in thread
From: chenzefeng @ 2020-04-24  1:24 UTC (permalink / raw)
  To: libc-alpha, fw, dj, zackw; +Cc: liucheng32, chenzefeng2, zengweilin

when we call functons as follow:
	setenv("MALLOC_TRACE", "/tmp/mtrace.log", 0);
	mtrace();
	...
	muntrace();
It would cause memleak, for the mtrace malloc some memory:
	mtd = malloc(TRACE_BUFFER_SIZE);
and it would not be free. Therefore it should be freed in muntrace.

Signed-off-by: chenzefeng <chenzefeng2@huawei.com>
---
 malloc/mtrace.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/malloc/mtrace.c b/malloc/mtrace.c
index 7e7719df97..61f4ca3520 100644
--- a/malloc/mtrace.c
+++ b/malloc/mtrace.c
@@ -365,4 +365,6 @@ muntrace (void)
 
   fprintf (f, "= End\n");
   fclose (f);
+  free (malloc_trace_buffer);
+  malloc_trace_buffer = NULL;
 }
-- 
2.12.3


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-04-24  1:24 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-24  1:24 [PATCH v4] malloc: fix memleak in function muntrace chenzefeng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).