[PATCH] manual/jobs.texi: remove unused var from example code

[PATCH] manual/jobs.texi: remove unused var from example code

[Aurelien Aptel]

The do_job_notification() function defines a variable without using
it. Remove it.
---
 manual/job.texi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/manual/job.texi b/manual/job.texi
index 05a42ea820..42cb9fb26d 100644
--- a/manual/job.texi
+++ b/manual/job.texi
@@ -860,7 +860,6 @@ void
 do_job_notification (void)
 @{
   job *j, *jlast, *jnext;
-  process *p;
 
   /* @r{Update status information for child processes.}  */
   update_status ();
-- 
2.26.2

Re: [PATCH] manual/jobs.texi: remove unused var from example code

[Aurélien Aptel]

ping

On Sat, May 23, 2020 at 9:18 PM Aurelien Aptel <aurelien.aptel@gmail.com> wrote:
>
> The do_job_notification() function defines a variable without using
> it. Remove it.
> ---
>  manual/job.texi | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/manual/job.texi b/manual/job.texi
> index 05a42ea820..42cb9fb26d 100644
> --- a/manual/job.texi
> +++ b/manual/job.texi
> @@ -860,7 +860,6 @@ void
>  do_job_notification (void)
>  @{
>    job *j, *jlast, *jnext;
> -  process *p;
>
>    /* @r{Update status information for child processes.}  */
>    update_status ();
> --
> 2.26.2
>

Re: [PATCH] manual/jobs.texi: remove unused var from example code

[Carlos O'Donell]

On 5/23/20 3:18 PM, Aurelien Aptel via Libc-alpha wrote:
> The do_job_notification() function defines a variable without using
> it. Remove it.

OK for master.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

> ---
>  manual/job.texi | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/manual/job.texi b/manual/job.texi
> index 05a42ea820..42cb9fb26d 100644
> --- a/manual/job.texi
> +++ b/manual/job.texi
> @@ -860,7 +860,6 @@ void
>  do_job_notification (void)
>  @{
>    job *j, *jlast, *jnext;
> -  process *p;
>  
>    /* @r{Update status information for child processes.}  */
>    update_status ();
> 


-- 
Cheers,
Carlos.

Re: [PATCH] manual/jobs.texi: remove unused var from example code

[Florian Weimer]

* Carlos O'Donell via Libc-alpha:

> On 5/23/20 3:18 PM, Aurelien Aptel via Libc-alpha wrote:
>> The do_job_notification() function defines a variable without using
>> it. Remove it.
>
> OK for master.
>
> Reviewed-by: Carlos O'Donell <carlos@redhat.com>

Are you going to apply this?

If you do, please be careful because due to the mailing list mangling,
you cannot use “git am”.

Thanks,
Florian

Re: [PATCH] manual/jobs.texi: remove unused var from example code

[Carlos O'Donell]

On 6/3/20 5:07 PM, Florian Weimer wrote:
> * Carlos O'Donell via Libc-alpha:
> 
>> On 5/23/20 3:18 PM, Aurelien Aptel via Libc-alpha wrote:
>>> The do_job_notification() function defines a variable without using
>>> it. Remove it.
>>
>> OK for master.
>>
>> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> 
> Are you going to apply this?

I am.

> If you do, please be careful because due to the mailing list mangling,
> you cannot use “git am”.

Patchwork sees things before mangling, and my workflow takes advantage of that.

# git-pw patch apply 39357;

*AND* for the gold star, it auto-applies my reviewed-by line because patchwork
is tracking them (along with other tags).

commit 74edc05817c126212c826c1a046a9465d0efe287 (HEAD -> master)
Author: Aurélien Aptel <aurelien.aptel@gmail.com>
Date:   Sat May 23 21:18:09 2020 +0200

    manual/jobs.texi: remove unused var from example code
    
    The do_job_notification() function defines a variable without using
    it. Remove it.
    Reviewed-by: Carlos O'Donell <carlos@redhat.com>

commit a7a3435c9a0769744c7748f9d95510d0a99be7d1 (origin/master, origin/HEAD)
...

Isn't that nice!

Just built the manual, and verified the pdf looks good.

Commited.

-- 
Cheers,
Carlos.

Re: [PATCH] manual/jobs.texi: remove unused var from example code

[Aurélien Aptel]

Great, thanks for applying the patch.

While reading and using this doc I also found a more important bug in
the example code, for which a bug was already opened 3 years ago but
not addressed:

https://sourceware.org/bugzilla/show_bug.cgi?id=22590

The sample code in the doc *cannot* work if SIGCHLD is ignored.
The quick fix would be to simply remove the `signal (SIGCHLD,
SIG_IGN);` line from Section 28.6.2 Initializing the Shell.
I've personally lost a lot of time on this... I can send a patch for
that if you'd like.

Cheers,