From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <christian.brauner@ubuntu.com>
Received: from youngberry.canonical.com (youngberry.canonical.com
 [91.189.89.112])
 by sourceware.org (Postfix) with ESMTPS id D7C293984042
 for <libc-alpha@sourceware.org>; Wed, 27 May 2020 10:31:03 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D7C293984042
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=ubuntu.com
Authentication-Results: sourceware.org;
 spf=none smtp.mailfrom=christian.brauner@ubuntu.com
Received: from ip5f5af183.dynamic.kabel-deutschland.de ([95.90.241.131]
 helo=wittgenstein) by youngberry.canonical.com with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2)
 (envelope-from <christian.brauner@ubuntu.com>)
 id 1jdtKw-0005g7-Q9; Wed, 27 May 2020 10:31:02 +0000
Date: Wed, 27 May 2020 12:31:02 +0200
From: Christian Brauner <christian.brauner@ubuntu.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 3/3] Linux: Require properly configured /dev/pts for PTYs
Message-ID: <20200527103102.u3jti3yngvj2rnes@wittgenstein>
References: <cover.1590574208.git.fweimer@redhat.com>
 <cfe04259c4ce7addd48e9479ad6a620967681f34.1590574208.git.fweimer@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <cfe04259c4ce7addd48e9479ad6a620967681f34.1590574208.git.fweimer@redhat.com>
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,
 SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 27 May 2020 10:31:05 -0000

On Wed, May 27, 2020 at 12:14:37PM +0200, Florian Weimer via Libc-alpha wrote:
> Current systems do not have BSD terminals, so the fallback code in
> posix_openpt/getpt does not do anything.  Also remove the file system
> check for /dev/pts.  Current systems always have a devpts file system
> mounted there if /dev/ptmx exists.

Good change!
In addition, on newer kernels you also have TIOCGPTPEER which wouldn't
even require /dev/pts be present and permits race-free access to a
/dev/pts/* device solely based on the /dev/ptmx fd. And we've made sure
that glibc already supports that.

So ack from me.
Christian