From: Lukasz Majewski <lukma@denx.de>
To: Joseph Myers <joseph@codesourcery.com>,
Paul Eggert <eggert@cs.ucla.edu>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: Alistair Francis <alistair23@gmail.com>,
Alistair Francis <alistair.francis@wdc.com>,
GNU C Library <libc-alpha@sourceware.org>,
Siddhesh Poyarekar <siddhesh@gotplt.org>,
Florian Weimer <fweimer@redhat.com>,
Zack Weinberg <zackw@panix.com>,
Carlos O'Donell <carlos@redhat.com>,
Andreas Schwab <schwab@suse.de>, Lukasz Majewski <lukma@denx.de>
Subject: [RFC 00/12] [RFC] y2038: Convert timespec_{sub|add|create} in support to be Y2038 safe
Date: Mon, 1 Jun 2020 16:07:28 +0200 [thread overview]
Message-ID: <20200601140740.16371-1-lukma@denx.de> (raw)
This patch set is the first attempt to convert functions utilized by nptl and
pthreads to support 64 bit time.
First timespec* functions are renamed to have common "__" prefix for internal
functions. This is a preparatory work for further conversion.
One question with this patch set is how shall we tackle the conversion
of time related functions (like e.g. ./support/timespec_add) used internally in
glibc as helper functions for internal code or tests.
I could follow the approach used for glibc syscalls (like clock_settime) to have
two versions depending on __TIMESIZE and __WORDSIZE, but this seems to be an
overkill for internally used functions.
Patches with "Convert:" prefix replace struct timespec with struct __timespec64
in timespec_* functions. This is necessary to have in-glibc proper support for
64 bit time.
The problem is with instant replacement of struct timespec with struct
__timespec64 in glibc internal code (and tests).
For replacing timesize with __timesize64 I could:
- Replace its occurences in relevant directories - like ./nptl or
./sysdeps/pthreads
- Replace them in functions (tests) and use explicit conversion functions - like
valid_timespec_to_timespec64()
- Replace _all_ occurences of struct timespec with struct __timespec64 at once
with using sed on glibc tree.
The last option seems to be the most appealing as we already use __timespec64
(with its aliassing) for some core system syscalls (like clock_gettime).
However, such patch shall be applied just after the release of new stable
version to have time for potential fixes.
Lukasz Majewski (12):
doc: Fix wording and formattine in ./support/README
y2038: Rename timespec_compare to __timespec_compare
y2038: Rename make_timespec to __make_timespec
y2038: Rename xclock_gettime to __xclock_gettime
y2038: Rename xclock_now to __xclock_now
y2038: Rename timespec_sub to __timespec_sub
y2038: Rename timespec_add to __timespec_add
y2038: Convert __make_timespec to be Y2038 safe
y2038: Convert __xclock_gettime to be Y2038 safe
y2038: Convert __xclock_now to be Y2038 safe
y2038: Convert timespec* files in ./support to be Y2038 safe
y2038: Convert timespec_* from posix-timer.h to be Y2038 safe
nptl/tst-eintr2.c | 4 ++--
nptl/tst-eintr5.c | 4 ++--
nptl/tst-rwlock6.c | 14 +++++++-------
nptl/tst-rwlock7.c | 10 +++++-----
nptl/tst-rwlock9.c | 10 +++++-----
nptl/tst-sem17.c | 2 +-
nptl/tst-sem5.c | 4 ++--
support/README | 4 ++--
support/timespec-add.c | 12 ++++++------
support/timespec-sub.c | 18 +++++++++---------
support/timespec.c | 12 ++++++------
support/timespec.h | 27 ++++++++++++++-------------
support/xclock_gettime.c | 5 ++---
support/xtime.h | 9 +++++----
sysdeps/mach/clock_nanosleep.c | 4 ++--
sysdeps/pthread/posix-timer.h | 11 ++++++-----
sysdeps/pthread/timer_gettime.c | 4 ++--
sysdeps/pthread/timer_routines.c | 14 +++++++-------
sysdeps/pthread/timer_settime.c | 4 ++--
sysdeps/pthread/tst-cond11.c | 2 +-
sysdeps/pthread/tst-cond26.c | 2 +-
sysdeps/pthread/tst-cond27.c | 4 ++--
sysdeps/pthread/tst-join14.c | 2 +-
sysdeps/pthread/tst-join3.c | 8 ++++----
sysdeps/pthread/tst-join5.c | 12 ++++++------
sysdeps/pthread/tst-mutex5.c | 12 ++++++------
sysdeps/pthread/tst-mutex9.c | 4 ++--
sysdeps/pthread/tst-rwlock14.c | 2 +-
28 files changed, 111 insertions(+), 109 deletions(-)
--
2.20.1
next reply other threads:[~2020-06-01 14:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 14:07 Lukasz Majewski [this message]
2020-06-01 14:07 ` [RFC 01/12] doc: Fix wording and formattine in ./support/README Lukasz Majewski
2020-06-01 14:07 ` [RFC 02/12] y2038: Rename timespec_compare to __timespec_compare Lukasz Majewski
2020-06-01 14:07 ` [RFC 03/12] y2038: Rename make_timespec to __make_timespec Lukasz Majewski
2020-06-01 14:07 ` [RFC 04/12] y2038: Rename xclock_gettime to __xclock_gettime Lukasz Majewski
2020-06-01 14:07 ` [RFC 05/12] y2038: Rename xclock_now to __xclock_now Lukasz Majewski
2020-06-01 14:07 ` [RFC 06/12] y2038: Rename timespec_sub to __timespec_sub Lukasz Majewski
2020-06-01 14:07 ` [RFC 07/12] y2038: Rename timespec_add to __timespec_add Lukasz Majewski
2020-06-01 14:07 ` [RFC 08/12] y2038: Convert __make_timespec to be Y2038 safe Lukasz Majewski
2020-06-01 14:07 ` [RFC 09/12] y2038: Convert __xclock_gettime " Lukasz Majewski
2020-06-01 14:07 ` [RFC 10/12] y2038: Convert __xclock_now " Lukasz Majewski
2020-06-01 14:07 ` [RFC 11/12] y2038: Convert timespec* files in ./support " Lukasz Majewski
2020-06-01 14:07 ` [RFC 12/12] y2038: Convert timespec_* from posix-timer.h " Lukasz Majewski
2020-06-02 18:05 ` [RFC 00/12] [RFC] y2038: Convert timespec_{sub|add|create} in support " Joseph Myers
2020-06-03 11:42 ` Lukasz Majewski
2020-06-03 12:53 ` [Y2038] Replacement of struct timespec with struct __timespec64 in glibc internal code Lukasz Majewski
2020-06-03 17:28 ` Joseph Myers
2020-06-03 20:45 ` Lukasz Majewski
2020-06-24 12:26 ` Lukasz Majewski
2020-06-24 12:43 ` Andreas Schwab
2020-06-24 20:39 ` Lukasz Majewski
2020-06-24 22:10 ` Joseph Myers
2020-06-24 17:43 ` Joseph Myers
2020-06-08 22:23 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200601140740.16371-1-lukma@denx.de \
--to=lukma@denx.de \
--cc=adhemerval.zanella@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=carlos@redhat.com \
--cc=eggert@cs.ucla.edu \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@suse.de \
--cc=siddhesh@gotplt.org \
--cc=zackw@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).